Skip to content

Consider credentials as sensitive data#252

Merged
bradgessler merged 1 commit intosuperfly:mainfrom
jonathanhefner:rails-consider-credentials-sensitive
Aug 11, 2022
Merged

Consider credentials as sensitive data#252
bradgessler merged 1 commit intosuperfly:mainfrom
jonathanhefner:rails-consider-credentials-sensitive

Conversation

@jonathanhefner
Copy link
Copy Markdown
Contributor

Credentials often include sensitive data, so it would be better to not suggest putting them in fly.toml.

This commit also changes the fly.toml example variable from LOCALE to RAILS_LOG_TO_STDOUT, to avoid implying that LOCALE has any effect by default, such as setting I18n.default_locale. (Note that RAILS_LOG_TO_STDOUT only has to be a nonblank string, so the example value used here is x, to avoid a boolean connotation.)

Credentials often include sensitive data, so it would be better to not
suggest putting them in `fly.toml`.

This commit also changes the `fly.toml` example variable from `LOCALE`
to `RAILS_LOG_TO_STDOUT`, to avoid implying that `LOCALE` has any effect
by default, such as setting `I18n.default_locale`.  (Note that
`RAILS_LOG_TO_STDOUT` only [has to be a nonblank string][1], so the
example value used here is `x`, to avoid a boolean connotation.)

[1]: https://github.com/rails/rails/blob/v7.0.3/railties/lib/rails/generators/rails/app/templates/config/environments/production.rb.tt#L97
@bradgessler bradgessler merged commit 40555ed into superfly:main Aug 11, 2022
kcmartin added a commit that referenced this pull request Apr 24, 2026
* Expand integrating flyctl guide

Full replacement of the thin page with token types and least-privilege guidance, GitHub Actions patterns, jq examples, build modes, and generic CI setup. Closes #252 (docs-tracking).

* incorporate reviewer feedback

* update nav to match doc title

* remove triple dashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants