flaps: move Wait to options and support multi-state#210
Merged
Conversation
dangra
force-pushed
the
flaps-wait-options
branch
from
a9718a6 to
a726c92
Compare
dangra
added a commit
to superfly/flyctl
that referenced
this pull request
Mar 16, 2026
Replace the old Wait(machine *fly.Machine, state string, timeout) signature with the new options-based API: Wait(machineID string, waitOpts ...WaitOption). All 11 call sites are updated to use WithWaitStates and WithWaitTimeout. Mocks, the in-memory test client, and the gomock-generated mock are updated to match the new interface.
3 tasks
dangra
added a commit
to superfly/flyctl
that referenced
this pull request
Mar 16, 2026
Replace the old Wait(machine *fly.Machine, state string, timeout) signature with the new options-based API: Wait(machineID string, waitOpts ...WaitOption). All 11 call sites are updated to use WithWaitStates and WithWaitTimeout. Mocks, the in-memory test client, and the gomock-generated mock are updated to match the new interface.
dangra
added a commit
to superfly/flyctl
that referenced
this pull request
Mar 16, 2026
* port to flaps.Wait options API (superfly/fly-go#210) Replace the old Wait(machine *fly.Machine, state string, timeout) signature with the new options-based API: Wait(machineID string, waitOpts ...WaitOption). All 11 call sites are updated to use WithWaitStates and WithWaitTimeout. Mocks, the in-memory test client, and the gomock-generated mock are updated to match the new interface. * upgrade fly-go to v0.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flaps.Client.Waitmachine argument with explicitmachineIDand a functional options APIstatevalues,timeout,version, andfrom_event_id, with default/clamped timeout behavior preservedTesting