Retry idempotent requests on ECONNRESET#226
Merged
rianmcguirefly merged 2 commits intomainfrom Apr 28, 2026
Merged
Conversation
rianmcguirefly
force-pushed
the
rm/retry-conn-reset
branch
from
24f03b6 to
ff9a476
Compare
rianmcguirefly
force-pushed
the
rm/retry-conn-reset
branch
from
ff9a476 to
478678e
Compare
rianmcguirefly
force-pushed
the
rm/retry-conn-reset
branch
from
478678e to
e496ea7
Compare
rianmcguirefly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the API clients more robust to transient network issues.
fly.Clientandfly.tracingGenqlientClient(GraphQL clients): retry GraphQL queries only.flaps.Client: retry GET requests. We can expand this on an endpoint-by-endpoint basis later.There's an existing
rehttptransport inNewHTTPClientthat applies automatic retry, but it doesn't catchECONNRESET. It also operates at the transport layer and can't reliably distinguish idempotent requests that are safe to retry after a connection reset.Retry policy: Exponential backoff - 100ms initial, 500ms cap, 50% jitter, max 2 retries