Skip to content

chore(setup): update nodejs runtime#108

Merged
bglw merged 4 commits intosuperfly:masterfrom
p-j:chore/upgrade-node-runtime
Apr 8, 2026
Merged

chore(setup): update nodejs runtime#108
bglw merged 4 commits intosuperfly:masterfrom
p-j:chore/upgrade-node-runtime

Conversation

@p-j
Copy link
Copy Markdown
Contributor

@p-j p-j commented Mar 12, 2026

Updating the nodejs runtime for setup-flyctl to address the warning that is currently outputted on workflows that use it.

Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: superfly/flyctl-actions/setup-flyctl@master. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

Additionally, upgrading related dependencies

fixes #109

@p-j
Copy link
Copy Markdown
Contributor Author

p-j commented Mar 25, 2026

@lubien @jeromegn if you guys have a moment to review this 🙏🏻

I've been using my fork for our preview env deployments/cleanup for the past 2 weeks (100+ deployments) with no issues.

@dangra
Copy link
Copy Markdown
Member

dangra commented Apr 7, 2026

@p-j the build step failed due to differences in the committed compiled JS

> ncc build src/main.ts --license LICENSE.txt --out dist

ncc: Version 0.38.4
ncc: Compiling file index.js into CJS
ncc: Using typescript@5.9.3 (local user-provided)
   8kB  dist/LICENSE.txt
1125kB  dist/index.js
1133kB  [2604ms] - ncc 0.38.4
diff --git a/setup-flyctl/dist/LICENSE.txt b/setup-flyctl/dist/LICENSE.txt
index e66aa35..64cd2cb 100644
Binary files a/setup-flyctl/dist/LICENSE.txt and b/setup-flyctl/dist/LICENSE.txt differ
diff --git a/setup-flyctl/dist/index.js b/setup-flyctl/dist/index.js
index ef2e1d4..ee4a23f 100644
Binary files a/setup-flyctl/dist/index.js and b/setup-flyctl/dist/index.js differ

Copy link
Copy Markdown
Contributor

@bglw bglw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bglw bglw merged commit ed8efb3 into superfly:master Apr 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade setup-flyctl action from Node.js 20 to Node.js 24

6 participants