Fly Console should always allocate pty#4802
Merged
swilson-fly merged 1 commit intomasterfrom Apr 7, 2026
Merged
Conversation
lesliebc
approved these changes
Apr 3, 2026
Contributor
Author
|
Failing check is due to an unrelated issue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
In #4703 fly console was updated to more closely match
fly ssh consolein behaviour. This changed how it allocated ptys for the connection, making it so it wouldn't allocate it if a command is specified.However
fly consoleuses theconsole_commandconfig in the toml, as it's command even if a-cisn't specified so this is always true. This meant that it always stopped allocating ptys, breaking the main functionality offly console. This command is almost always used for opening a rails console for debugging, so it's always interactive.This reverts the change from 4703 back to it's original, always interactive behaviour. As an alternative we could split out console_command vs
--console, but since this allocates a whole new machine using it for a non-interactive, one off result seems too heavy. For one offs users should probably usefly ssh console --commandHow:
Reverts console behaviour back to always allocating a pty.
Related to:
PR 4703 cc: @mattp-fly
Documentation