Skip to content

Fly Console should always allocate pty#4802

Merged
swilson-fly merged 1 commit intomasterfrom
fix/console-pty-allocation
Apr 7, 2026
Merged

Fly Console should always allocate pty#4802
swilson-fly merged 1 commit intomasterfrom
fix/console-pty-allocation

Conversation

@swilson-fly
Copy link
Copy Markdown
Contributor

@swilson-fly swilson-fly commented Apr 3, 2026

Change Summary

What and Why:
In #4703 fly console was updated to more closely match fly ssh console in behaviour. This changed how it allocated ptys for the connection, making it so it wouldn't allocate it if a command is specified.

However fly console uses the console_command config in the toml, as it's command even if a -c isn't specified so this is always true. This meant that it always stopped allocating ptys, breaking the main functionality of fly console. This command is almost always used for opening a rails console for debugging, so it's always interactive.

This reverts the change from 4703 back to it's original, always interactive behaviour. As an alternative we could split out console_command vs --console, but since this allocates a whole new machine using it for a non-interactive, one off result seems too heavy. For one offs users should probably use fly ssh console --command

How:

Reverts console behaviour back to always allocating a pty.

Related to:

PR 4703 cc: @mattp-fly


Documentation

  • Fresh Produce
  • In superfly/docs, or asked for help from docs team
  • n/a

@swilson-fly
Copy link
Copy Markdown
Contributor Author

Failing check is due to an unrelated issue: aborted: machine is replacing: concurrent update in progress

@swilson-fly swilson-fly merged commit 26f5dd0 into master Apr 7, 2026
35 of 37 checks passed
@swilson-fly swilson-fly deleted the fix/console-pty-allocation branch April 7, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants