Fix "concurrent update in progress" errors during canary deploys#4825
Merged
Fix "concurrent update in progress" errors during canary deploys#4825
Conversation
385beab to
fa7a7a8
Compare
Member
|
@rianmcguirefly I merged this after it passed all tests so it is included in today's auto release. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
Avoid possibility of failure during a canary deploy if the machine that we run the canary update on is currently stopped.
Example error:
Failed to update machines: failed to update machine <machine id>: failed to update VM <machine id>: aborted: machine is replacing: concurrent update in progress Retrying...The machines API blocks concurrent updates to a machine, so we need to ensure that doesn't happen.
How:
Fix all the things
replacingback tostopped) before continuing