fix(auth): tighten permissions on ~/.docker/config.json#4916
Merged
Conversation
flyctl wrote ~/.docker/config.json at 0o644. Match upstream Docker CLI (0o600) and chmod explicitly after the write so the mode applies on rewrite as well as on initial creation (os.WriteFile only honors perm on file creation).
go reports 0o777 for directory modes on windows regardless of perm arg, so the mode assertions in these tests aren't meaningful there. configureDockerJSON (the only caller) already bails on windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flyctl wrote ~/.docker/config.json at 0o644. Match upstream Docker CLI (0o600) and chmod explicitly after the write so the mode applies on rewrite as well as on initial creation (os.WriteFile only honors perm on file creation).