refactor: Bound WireGuard connect context#4941
Merged
Merged
Conversation
Previously, the context used by initiating and maintaining WireGuard connections was the same. This forced the fly agent to pass in an unbound context which could hang forever if attempting to connect to a nonexistant service.
98146d1 to
842cf37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the context used by initiating and maintaining WireGuard
connections was the same. This forced the fly agent to pass in an
unbound context which could hang forever if attempting to connect to a
nonexistant service.
This PR is part of a stack: