Merged
Conversation
aa47b67 to
69dc66b
Compare
69dc66b to
0c4eb2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the "trace log" so that it can be written to disk and the logs will automatically be rolled. Trace logging can produce A LOT of data quickly but we typically only care about very recent logs when an issue occurs.
Usage
The existing
-tracingflag still works and can be used to enable the trace log via STDOUT. There is also a newtracingconfig section for enabling the trace log printing to disk:This default configuration will produce a file called
/path/to/trace.logand once that log reaches 64MB then it will be rolled over to a new file with a time-based name (e.g./path/to/trace.2022-12-15T14-11-07.991.log.gz). Once 10 logs files have been produced, the oldest one will be deleted when a new log file is written.