Wait for SHM changes to flush before exit#351
Merged
benbjohnson merged 1 commit intomainfrom Jun 20, 2023
Merged
Conversation
benbjohnson
force-pushed
the
fix-shm-test-lockup
branch
from
ca950e1 to
a3c68ca
Compare
benbjohnson
added a commit
that referenced
this pull request
Jun 20, 2023
This reverts commit 9b998b7.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the SHM access was changed to go through the FUSE mount (#346), this caused a race condition on FUSE shutdown for pending changes to the SHM. The FUSE connection is now explicitly closed and internal changes to SHM are sync'd to FUSE. There is also a "mount ready" flag on the store to indicate when the FUSE mount is available so that the store does not attempt to access it before mount or after unmount.