Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Fix parsing of attendee when common name is missing#8

Merged
sanketfirodiya merged 1 commit intomasterfrom
fix-attendee-parsing
Feb 14, 2018
Merged

Fix parsing of attendee when common name is missing#8
sanketfirodiya merged 1 commit intomasterfrom
fix-attendee-parsing

Conversation

@sanketfirodiya
Copy link
Copy Markdown

@sanketfirodiya sanketfirodiya commented Feb 14, 2018

Parsing would be incorrect if the attendee had CN missing, e.g.:

ATTENDEE;CUTYPE=RESOURCE;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;X-NUM-GUEST
 S=0:mailto:superhuman.com_3633323632323332383537@resource.calendar.google.c
 om

vs when its not missing:

ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=rahul@superhuman.com;X-NUM-GUESTS=0:mailto:rahul@superhuman.com

This was happening because we reuse the placeholder string to parse out different components. I think its cleaner and less error prone if we parse out each component in its own string.

Fixes https://github.com/superhuman/superhuman-ios/issues/2374

@emuye emuye removed their assignment Feb 14, 2018
@sanketfirodiya sanketfirodiya merged commit 42c8671 into master Feb 14, 2018
@sanketfirodiya sanketfirodiya deleted the fix-attendee-parsing branch February 14, 2018 02:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants