fix(jsonc): add trailing comma support#16
Merged
nexxeln merged 1 commit intosupermemoryai:mainfrom Jan 5, 2026
Merged
Conversation
Signed-off-by: assagman <ahmetsercansagman@gmail.com>
Contributor
Author
|
I've just realized that there is an another PR for this purpose: #14 However, this PR contains super minimal changeset. |
nexxeln
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsonc files may or may not contain trailing comma.
Please see:
In the previous version, having trailing commas cause supermemory plugin to silently fail to load configuration. This changeset aims to add support to have trailing commas in
supermemory.jsoncfile, by extending regex to remove trailing comma.