Skip to content

Fix Windows auth URL opener#50

Merged
MaheshtheDev merged 3 commits into
mainfrom
codex/windows-auth-opener
Jun 5, 2026
Merged

Fix Windows auth URL opener#50
MaheshtheDev merged 3 commits into
mainfrom
codex/windows-auth-opener

Conversation

@ishaanxgupta
Copy link
Copy Markdown
Contributor

@ishaanxgupta ishaanxgupta commented Jun 3, 2026

What changed

  • Replaced the OpenCode login flow's shell-string browser opener with a guarded openUrl helper.
  • The Windows path now uses rundll32.exe url.dll,FileProtocolHandler first, with a cmd /c start fallback.
  • Auth now returns a clear failure if opening the browser fails instead of waiting for timeout.
  • Fixed small TypeScript strictness issues so the package's declared validation commands pass on this checkout.

Why

On Windows, launching a long OAuth URL through shell start can be parsed as a local target or otherwise mishandled. This is the same class of issue fixed for the Codex and Amp plugins, where /supermemory-login can route users away from the intended browser OAuth page.

@ishaanxgupta ishaanxgupta changed the title [codex] Fix Windows auth URL opener Fix Windows auth URL opener Jun 3, 2026
@ishaanxgupta ishaanxgupta marked this pull request as ready for review June 3, 2026 12:07
Copy link
Copy Markdown
Member

@MaheshtheDev MaheshtheDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaheshtheDev MaheshtheDev merged commit f932847 into main Jun 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants