Skip to content

Add memory drawer#1015

Merged
MaheshtheDev merged 5 commits into
mainfrom
memory-drawer
May 29, 2026
Merged

Add memory drawer#1015
MaheshtheDev merged 5 commits into
mainfrom
memory-drawer

Conversation

@ved015
Copy link
Copy Markdown
Member

@ved015 ved015 commented May 27, 2026

Revamp memory model in phone to memory-drawer comes up with smooth animation

Screenshot 2026-05-29 at 8 40 12 PM Screenshot 2026-05-29 at 8 40 24 PM Screenshot 2026-05-29 at 8 40 43 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 27, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 87723cb May 29 2026, 03:16 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 27, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 87723cb Commit Preview URL

Branch Preview URL
May 29 2026, 03:16 PM

@graphite-app graphite-app Bot requested a review from Dhravya May 27, 2026 17:32
@claude
Copy link
Copy Markdown

claude Bot commented May 27, 2026

Claude finished @ved015's task in 1m 35s —— View job


Review Complete

  • Gathering context from PR changes
  • Analyzing changed files for bugs and security issues
  • Checking boundary code and surrounding context
  • Submitting review

Overview: Refactors the document modal to use a Drawer component on mobile devices, adding tab-based navigation between Content and Insights views with responsive legend/graph adjustments.

Issues found: None — this looks good to ship.

The implementation is clean and well-structured:

  • Shared content extracted into modalContent variable, eliminating code duplication between Dialog and Drawer
  • Mobile detection with isMobile correctly drives the conditional rendering at the component level
  • Proper imports for Drawer, DrawerContent, DrawerTitle from @repo/ui/components/drawer and Tabs components
  • DialogPrimitive import already present (line 16) for the close button functionality
  • All optional chaining (_document?.title, _document?.memoryEntries, etc.) properly guards against undefined access
  • The hasDocumentInsights boolean correctly determines whether to show the tabbed interface on mobile
  • Legend component properly handles compact mode with scrollable content and sensible height constraints (maxHeight - 56 with 112px minimum)
  • Graph positioning adjusts correctly for compact viewports (12px vs 16px spacing)

Score: 10/10

github-actions Bot and others added 2 commits May 27, 2026 17:34
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Refactors the document modal to use a Drawer component on mobile devices, improving the mobile UX with better gesture support and responsive legend/graph components.

Issues found: None — this looks good to ship.

The implementation is clean:

  • Shared content extracted into modalContent variable, avoiding code duplication between Dialog and Drawer
  • Mobile/desktop conditional rendering is straightforward with the isMobile check at render time
  • Legend component properly handles compact mode with scrollable content and sensible height constraints
  • Graph positioning adjusts correctly for compact viewports

Score: 10/10

ved015 and others added 2 commits May 29, 2026 20:41
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Copy Markdown
Member

@MaheshtheDev MaheshtheDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaheshtheDev MaheshtheDev merged commit fc08bd8 into main May 29, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants