Skip to content

add edit feature , reasoning mode, message queue in nova chat#1018

Merged
MaheshtheDev merged 13 commits into
mainfrom
nova_chat
Jun 2, 2026
Merged

add edit feature , reasoning mode, message queue in nova chat#1018
MaheshtheDev merged 13 commits into
mainfrom
nova_chat

Conversation

@ved015
Copy link
Copy Markdown
Member

@ved015 ved015 commented May 28, 2026

ux-revamp-1780216464737-compressed.mp4

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 28, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 85f9812 Commit Preview URL

Branch Preview URL
Jun 02 2026, 04:14 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 28, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 85f9812 Jun 02 2026, 04:12 PM

@graphite-app graphite-app Bot requested a review from Dhravya May 28, 2026 11:28
@claude
Copy link
Copy Markdown

claude Bot commented May 28, 2026

Claude finished @ved015's task in 1m 42s —— View job


Review Complete

  • Gather context and read changed files
  • Analyze code for bugs, security issues, and logic errors
  • Complete review

Overview: Adds message editing, reasoning mode selection (instant/thinking), and a message queue system to Nova chat.

Issues found: None — this looks good to ship.

The implementation is solid:

  • Edit flow: submitEdit validates for empty text, draft state initializes correctly from the original message, and the textarea properly focuses on edit start.

  • Regeneration: The two-phase approach (truncate messages via setMessages, then send via useEffect once React processes the state) correctly handles React's batching. The refs (truncateFromMessageIdRef, pendingRegenerationRef, pendingSendSettingsRef) appropriately preserve transient state across re-renders.

  • Message queue: Properly enforces the 3-message limit. The dispatch tracking refs correctly ensure a queued message has started receiving a response before dispatching the next.

  • Click-outside handler: ReasoningSelector correctly cleans up the event listener, preventing memory leaks.

  • No security concerns: Message content is rendered as text, so no XSS risk.

Score: 9/10

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds message editing and reasoning effort selection (instant/thinking) to Nova chat.

Issues found: None — this looks good to ship.

The regeneration flow is well-designed with a two-phase approach: truncate messages first, then send via useEffect once React has processed the state update. The refs (truncateFromMessageIdRef, pendingRegenerationRef) correctly preserve transient state across re-renders, and the setTimeout(0) pattern ensures the truncate ref is available during request preparation but cleared afterward.

The click-outside handler in ReasoningSelector properly cleans up its event listener. Input validation in submitEdit prevents empty submissions. No XSS concerns since message content is rendered as text.

Score: 9/10

@ved015 ved015 changed the title add edit feature and thinking selection in nova chat add edit feature , reasoning mode, message queue in nova chat May 31, 2026
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds message editing, reasoning mode selection (instant/thinking), and a message queue system to Nova chat.

Issues found: None — this looks good to ship.

The implementation is solid:

  • Edit flow: submitEdit validates for empty text, draft state initializes correctly from the original message, and the textarea properly focuses on edit start.

  • Regeneration: The two-phase approach (truncate messages via setMessages, then send via useEffect once React processes the state) correctly handles React's batching. The refs (truncateFromMessageIdRef, pendingRegenerationRef, pendingSendSettingsRef) appropriately preserve transient state across re-renders without causing unnecessary renders.

  • Message queue: Properly enforces the 3-message limit with CHAT_QUEUE_LIMIT. The queuedDispatchInFlightRef/queuedDispatchSawResponseRef pattern correctly tracks whether a queued message has started receiving a response before dispatching the next.

  • Click-outside handler: ReasoningSelector correctly adds/removes the event listener in the cleanup function, preventing memory leaks.

  • No security concerns: Message content is rendered as text (not dangerouslySetInnerHTML), so no XSS risk.

Score: 9/10

@MaheshtheDev MaheshtheDev merged commit 73c320c into main Jun 2, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants