Skip to content

Remove redundant credits section#1019

Merged
MaheshtheDev merged 5 commits into
mainfrom
billing
May 29, 2026
Merged

Remove redundant credits section#1019
MaheshtheDev merged 5 commits into
mainfrom
billing

Conversation

@ved015
Copy link
Copy Markdown
Member

@ved015 ved015 commented May 28, 2026

Replaced add more credtis with buy credits

Screenshot 2026-05-29 at 8 10 16 PM

Modal colour scheme matches rest of the modals

Screenshot 2026-05-29 at 8 10 33 PM

Primary button and secondary button colour scheme matched

Screenshot 2026-05-29 at 8 10 49 PM

Primary button and secondary button colour scheme matched

Screenshot 2026-05-29 at 8 11 03 PM

@graphite-app graphite-app Bot requested a review from Dhravya May 28, 2026 12:38
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 28, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 6268353 May 29 2026, 02:50 PM

@claude
Copy link
Copy Markdown

claude Bot commented May 28, 2026

Claude finished @ved015's task in 55s —— View job


  • Gather context and review the PR changes
  • Verify the previous bug fix is still in place
  • Analyze the diff for any new issues
  • Submit review

Review Complete

Overview: This PR removes redundant usage display from the Credits section and simplifies the dialog structure.

Changes:

  • Removed duplicate "Usage this period" display from Credits section (already shown in Billing & Subscription section)
  • Moved the credits Dialog component outside of nested structure for cleaner organization
  • Simplified Credits card to show only top-up balance and purchase button
  • Removed "(optional)" label from "Top-up credits" heading
  • Updated modal styling to match other dialogs in the app
  • Refactored PillButton variants (dangerghost) in org-context

Previous issue status: The debug artifact true || hasPaidPlan from the previous review has been fixed (commit 582009a). The Credits section now correctly uses hasPaidPlan at line 940.

Issues found: None. The refactoring is clean and the bug has been addressed.

Score: 9/10 — Clean refactoring that reduces redundancy and improves code organization. Ready to merge.


@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 28, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 6268353 Commit Preview URL

Branch Preview URL
May 29 2026, 02:51 PM

claude[bot]
claude Bot previously requested changes May 28, 2026
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Removes the redundant usage display from the Credits section and simplifies the credits dialog structure.

Issues found:

  • Line 936: Debug artifact true || hasPaidPlan will always show the Credits section to all users regardless of subscription status. Should be just hasPaidPlan.

Score: 7/10

The refactoring looks clean, but the debug artifact must be removed before merge — it would expose the credits section to free-tier users who shouldn't see it.

Comment thread apps/web/components/settings/billing.tsx Outdated
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ved015
Copy link
Copy Markdown
Member Author

ved015 commented May 28, 2026

@claude pls review

@claude
Copy link
Copy Markdown

claude Bot commented May 28, 2026

Claude finished @ved015's task in 44s —— View job


  • Gather context and review the PR changes
  • Check if the previously identified bug was fixed
  • Analyze the diff for any remaining issues
  • Submit review

Review Complete

Overview: This PR removes redundant usage display from the Credits section and simplifies the dialog structure.

Changes:

  • Removed duplicate "Usage this period" display from Credits section (already shown in Billing & Subscription section)
  • Moved the credits Dialog component outside of nested structure for cleaner organization
  • Simplified Credits card to show only top-up balance and purchase button
  • Removed "(optional)" label from "Top-up credits" heading

Previous issue status: The debug artifact true || hasPaidPlan from the previous review has been fixed (commit 582009a). The Credits section now correctly uses hasPaidPlan at line 917.

Issues found: None. The refactoring is clean and the bug has been addressed.

Score: 9/10 — Clean refactoring that reduces redundancy and improves code organization. Ready to merge.


Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: This PR removes redundant usage display from the Credits section, restructures the Dialog component, and updates button styling.

Issues found:

  • Line 940: The debug artifact true || hasPaidPlan was fixed in commit 582009a but reintroduced in the latest commit 49ea8f9. This will show the Credits section to all users regardless of their subscription status.

Score: 7/10

The refactoring is clean otherwise, but the debug artifact must be removed before merge.

Comment thread apps/web/components/settings/billing.tsx
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ved015
Copy link
Copy Markdown
Member Author

ved015 commented May 29, 2026

@claude pls review the pr

@claude
Copy link
Copy Markdown

claude Bot commented May 29, 2026

Claude finished @ved015's task in 48s —— View job


  • Gather context and review the PR changes
  • Verify the true || hasPaidPlan bug fix is in place
  • Analyze the diff for code quality and issues
  • Submit review

Review Complete

Overview: This PR removes redundant usage display from the Credits section, restructures the dialog component, and updates styling for consistency.

Changes:

  • Removed duplicate "Usage this period" display from Credits section (already shown in Billing & Subscription)
  • Moved the Credits Dialog component outside the nested section structure for cleaner organization
  • Simplified Credits card to show only top-up balance and purchase button
  • Removed "(optional)" label from "Top-up credits" heading
  • Updated modal styling to match other dialogs (SURFACE_SHADOW, rounded corners, colors)
  • Refactored PillButton variants in org-context (dangerghost) for consistency

Bug fix verified: The debug artifact true || hasPaidPlan has been correctly removed. Line 921 now shows {hasPaidPlan ? ( which properly gates the Credits section to paid plan users only.

Issues found: None

Score: 9/10 — Clean refactoring that reduces redundancy and improves code organization. The previous bug has been addressed. Ready to merge.


View job

Copy link
Copy Markdown
Member

@MaheshtheDev MaheshtheDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaheshtheDev MaheshtheDev enabled auto-merge (squash) May 29, 2026 18:16
@MaheshtheDev MaheshtheDev merged commit 6fb42ad into main May 29, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants