Skip to content

fix(web): restore Nova onboarding analytics events#1023

Merged
graphite-app[bot] merged 1 commit into
mainfrom
analytics-onboarding-fix
May 29, 2026
Merged

fix(web): restore Nova onboarding analytics events#1023
graphite-app[bot] merged 1 commit into
mainfrom
analytics-onboarding-fix

Conversation

@MaheshtheDev
Copy link
Copy Markdown
Member

The onboarding rework moved the flow to app/(app)/onboarding and dropped the funnel tracking, so onboarding_completed stopped firing on 2026-05-02.

  • Wire onboarding_step_viewed across idle/processing/done/error transitions
  • Fire onboarding_completed on real completion (status=done) with source + memories_count
  • onboarding_profile_submitted now carries { source }
  • Add onboarding_skipped { from_step }
  • Remove dead onboardingCompleted() from InitialHeader and unused name/relatable helpers

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 29, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp ab068e2 May 29 2026, 07:56 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 29, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app ab068e2 Commit Preview URL

Branch Preview URL
May 29 2026, 07:56 PM

Copy link
Copy Markdown
Member Author


How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MaheshtheDev MaheshtheDev marked this pull request as ready for review May 29, 2026 18:49
@graphite-app graphite-app Bot requested a review from Dhravya May 29, 2026 18:49
@claude
Copy link
Copy Markdown

claude Bot commented May 29, 2026

Claude finished @MaheshtheDev's task in 1m 0s —— View job


PR Review Complete

  • Fetch PR diff and review new commits
  • Check for bugs, security issues, and logic errors
  • Post review summary

Overview: Restores onboarding analytics tracking that was lost during a refactor, and adds new integration card click tracking.

Issues found: None — this looks good to ship.

Verification notes:

  • The completedTrackedRef pattern correctly prevents double-firing of onboardingCompleted
  • The biome-ignore for exhaustive deps is justified — the effect intentionally fires per status transition, capturing detected and memoriesCount at render time
  • trackCard calls are placed before actions (mutations, navigation), which is correct for click tracking
  • connectionAuthStarted now passes provider context via onMutate, firing before the mutation
  • Removed onboardingNameSubmitted and onboardingRelatableSelected are confirmed dead code with no callers
  • The removed analytics.onboardingCompleted() in InitialHeader.handleSkip was dead code since showSkipOnboarding is never true

Score: 10/10

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Restores onboarding analytics tracking that was lost when the onboarding flow was moved, wiring up step views, completion, skip, and profile submission events.

Issues found: None — this looks good to ship.

Verification notes:

  • Confirmed onboardingNameSubmitted and onboardingRelatableSelected have no other callers in the codebase
  • Confirmed the removed analytics.onboardingCompleted() in InitialHeader was dead code — showSkipOnboarding is never passed as true anywhere
  • The completedTrackedRef pattern correctly prevents double-firing of completion events
  • The biome-ignore for exhaustive deps is correct — the effect intentionally fires per status transition, and values are captured at render time (React batches the state updates before the effect runs)
  • Type safety is maintained with the new OnboardingStep and OnboardingSource types

Score: 10/10

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 29, 2026

Merge activity

The onboarding rework moved the flow to app/(app)/onboarding and dropped the funnel tracking, so onboarding_completed stopped firing on 2026-05-02.

- Wire onboarding_step_viewed across idle/processing/done/error transitions
- Fire onboarding_completed on real completion (status=done) with source + memories_count
- onboarding_profile_submitted now carries { source }
- Add onboarding_skipped { from_step }
- Remove dead onboardingCompleted() from InitialHeader and unused name/relatable helpers
@graphite-app graphite-app Bot force-pushed the analytics-onboarding-fix branch from 57e3935 to ab068e2 Compare May 29, 2026 19:54
@graphite-app graphite-app Bot merged commit ab068e2 into main May 29, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants