Skip to content

security: fix critical DOM-based XSS in browser extension #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akhilesharora wants to merge 1 commit into from
Closed

security: fix critical DOM-based XSS in browser extension #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/browser-extension/entrypoints/content/chatgpt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,10 @@ function setupChatGPTPromptCapture() {
promptTextarea &&
!promptContent.includes("Supermemories of user")
) {
promptTextarea.innerHTML = `${promptTextarea.innerHTML} ${storedMemories}`
// Fix: Use textContent to prevent XSS injection
const memoriesContainer = document.createElement('div')
memoriesContainer.textContent = storedMemories
promptTextarea.appendChild(memoriesContainer)
promptContent = promptTextarea.textContent || ""
}

Expand Down
5 changes: 4 additions & 1 deletion apps/browser-extension/entrypoints/content/claude.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,10 @@ function setupClaudePromptCapture() {
contentEditableDiv &&
!promptContent.includes("Supermemories of user")
) {
contentEditableDiv.innerHTML = `${contentEditableDiv.innerHTML} ${storedMemories}`
// Fix: Use textContent to prevent XSS injection
const memoriesContainer = document.createElement('div')
memoriesContainer.textContent = storedMemories
contentEditableDiv.appendChild(memoriesContainer)
promptContent =
contentEditableDiv.textContent || contentEditableDiv.innerText || ""
}
Expand Down