Skip to content

Conversation

@muhammedhunaid
Copy link
Contributor

@muhammedhunaid muhammedhunaid commented Jan 23, 2026

Summary

  • Add missing r.memory fallback in getProfile() searchResults mapping
  • Aligns with existing search() method behavior (line 140)
  • Fixes empty memory content in MCP recall tool output

Related discussion: #694

Problem

The recall tool returns match percentages but empty memory content:

### Memory 1 (73% match)

### Memory 2 (72% match)

Root Cause

getProfile() at line 175 was missing r.memory in its fallback chain:

// Before
memory: limitByChars(r.content || r.context || ""),

// After  
memory: limitByChars(r.content || r.memory || r.context || ""),

Test plan

  • Verify recall returns memory content with the fix
  • Confirm search behavior unchanged

Add missing r.memory fallback in searchResults mapping to match the
search() method behavior. Fixes empty memory content in recall output.
Copilot AI review requested due to automatic review settings January 23, 2026 00:10
@graphite-app graphite-app bot requested a review from Dhravya January 23, 2026 00:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the MCP recall tool where memory content was not being displayed. The getProfile() method was missing r.memory in its fallback chain when mapping search results, causing empty memory content to be returned even when the memory field contained data.

Changes:

  • Added r.memory to the fallback chain in getProfile() method to align with the existing search() method behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MaheshtheDev MaheshtheDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaheshtheDev MaheshtheDev merged commit 3069bd6 into supermemoryai:main Jan 23, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants