Skip to content

fix: multi-select propagation bug and redesign selection toolbar#901

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-05-fix_multi-select_propagation_bug_and_redesign_selection_toolbar
May 5, 2026
Merged

fix: multi-select propagation bug and redesign selection toolbar#901
graphite-app[bot] merged 1 commit intomainfrom
05-05-fix_multi-select_propagation_bug_and_redesign_selection_toolbar

Conversation

@MaheshtheDev
Copy link
Copy Markdown
Member

No description provided.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 5, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp f14cf55 May 05 2026, 10:36 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 5, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app f14cf55 Commit Preview URL May 05 2026, 10:37 PM

Copy link
Copy Markdown
Member Author


How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MaheshtheDev MaheshtheDev marked this pull request as ready for review May 5, 2026 22:22
@graphite-app graphite-app Bot requested a review from Dhravya May 5, 2026 22:22
@claude
Copy link
Copy Markdown

claude Bot commented May 5, 2026

Claude finished @MaheshtheDev's task in 1m 12s —— View job


Review Complete

  • Fetch PR diff and understand changes
  • Review for bugs, security issues, and logic errors
  • Check surrounding code context
  • Submit review summary

Overview: Fixes multi-select not updating visually by moving selection state into Masonry item data, and fixes effectiveContainerTags to fall back to the default project when none selected.

Issues found: None — this looks good to ship.

The bug fix is sound: the previous approach stored isSelectionMode and selectedDocumentIds in a mutable ref for performance (to keep renderMasonryItem stable), but this prevented Masonry from detecting when selection state changed. By embedding isSelectionMode and isSelected directly in each MasonryItem and including them in the useMemo dependency array, the items array now changes when selection changes, correctly triggering re-renders.

Score: 10/10

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Fixes multi-select not updating visually by moving selection state into Masonry item data, and fixes effectiveContainerTags to fall back to the default project when none selected.

Issues found: None — this looks good to ship.

The bug fix is sound: the previous approach stored isSelectionMode and selectedDocumentIds in a mutable ref for performance (to keep renderMasonryItem stable), but this prevented Masonry from detecting when selection state changed. By embedding isSelectionMode and isSelected directly in each MasonryItem and including them in the useMemo dependency array, the items array now changes when selection changes, correctly triggering re-renders.

The stores/index.ts change ensures queries don't use an empty containerTags array when no projects are selected.

Score: 10/10

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 5, 2026

Merge activity

@graphite-app graphite-app Bot force-pushed the 05-05-fix_multi-select_propagation_bug_and_redesign_selection_toolbar branch from a3ec077 to f14cf55 Compare May 5, 2026 22:35
@graphite-app graphite-app Bot merged commit f14cf55 into main May 5, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants