Skip to content

fix: onboarding org creation issue on skip#906

Merged
graphite-app[bot] merged 1 commit into
mainfrom
05-06-fix_onboarding_org_creation_issue_on_skip
May 7, 2026
Merged

fix: onboarding org creation issue on skip#906
graphite-app[bot] merged 1 commit into
mainfrom
05-06-fix_onboarding_org_creation_issue_on_skip

Conversation

@MaheshtheDev
Copy link
Copy Markdown
Member

No description provided.

@MaheshtheDev MaheshtheDev marked this pull request as ready for review May 7, 2026 06:11
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 7, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app e8ec237 Commit Preview URL May 07 2026, 06:48 AM

@graphite-app graphite-app Bot requested a review from Dhravya May 7, 2026 06:11
Copy link
Copy Markdown
Member Author

MaheshtheDev commented May 7, 2026


How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown

claude Bot commented May 7, 2026

Claude finished @MaheshtheDev's task in 53s —— View job


Review Complete

  • Fetching PR diff
  • Analyzing code changes
  • Checking surrounding context
  • Submitting review

Overview: Fixes a bug where clicking "Skip for now" during onboarding would navigate away without ensuring an organization is created first.

Issues found: None — this looks good to ship.

The fix correctly:

  • Uses a ref-based guard (skippingRef) to prevent double-clicks
  • Calls ensureOrg() before navigation to guarantee the org exists
  • Handles errors by logging and resetting the guard
  • Awaits all async operations before navigating

Score: 10/10

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 7, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp e8ec237 May 07 2026, 06:45 AM

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Fixes a bug where clicking "Skip for now" during onboarding would navigate away without ensuring an organization is created first.

Issues found: None — this looks good to ship.

The fix correctly:

  • Uses a ref-based guard (skippingRef) to prevent double-clicks, which is the right pattern since no re-render is needed
  • Calls ensureOrg() before navigation to guarantee the org exists
  • Handles errors by logging and resetting the guard, keeping the user on the page
  • Awaits all async operations in ensureOrg() before navigating, so no race conditions

Score: 10/10

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 7, 2026

Merge activity

@graphite-app graphite-app Bot force-pushed the 05-06-fix_onboarding_org_creation_issue_on_skip branch from 5d6e493 to e8ec237 Compare May 7, 2026 06:44
@graphite-app graphite-app Bot merged commit e8ec237 into main May 7, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants