Skip to content

fix: remove excessive bottom padding below input bar on mobile dashboard#925

Merged
ishaanxgupta merged 1 commit into
mainfrom
vorflux/fix-mobile-input-bar-padding
May 11, 2026
Merged

fix: remove excessive bottom padding below input bar on mobile dashboard#925
ishaanxgupta merged 1 commit into
mainfrom
vorflux/fix-mobile-input-bar-padding

Conversation

@MaheshtheDev
Copy link
Copy Markdown
Member

Summary

Fixes excessive bottom padding below the input bar on the mobile dashboard view.

The fixed input bar wrapper had bottom-[4.5rem] on mobile, creating a 72px dead gap below it — originally intended for a mobile bottom nav bar that no longer exists. This change removes that offset and adjusts the scroll container padding accordingly.

Changes

  • apps/web/app/(app)/page.tsx — Removed conditional bottom-[4.5rem] mobile offset on the fixed input bar wrapper; now uses bottom-0 unconditionally
  • apps/web/components/dashboard-view.tsx — Reduced mobile scroll content bottom padding from pb-32 (128px) to pb-20 (80px) to match the new input bar position

Testing

Static Analysis

  • TypeScript type-check: Pass (all errors pre-existing in unrelated packages)
  • Biome lint on changed files: Pass (3 pre-existing warnings, none introduced)

Visual Layout (Playwright headless, 5 viewports)

Measured DOM metrics for the HomeChatComposer overlay wrapper:

Viewport Gap below overlay Result
Mobile 390x844 (iPhone 14) — initial 0 px Pass
Mobile 390x844 — scrolled to bottom 0 px Pass
Mobile 375x667 (iPhone SE) 0 px Pass
Desktop 1280x800 0 px Pass
Breakpoint 767px / 768px boundary 0 px Pass

Input bar is flush at the viewport bottom on all viewports. Desktop behavior unchanged.

- Remove dead bottom-[4.5rem] mobile offset on the fixed input bar wrapper
  in page.tsx. The input bar is fixed to inset-x-0 bottom-0 unconditionally
  now, eliminating an unnecessary conditional className via cn().
- Reduce mobile scroll content bottom padding from pb-32 to pb-20 in
  dashboard-view.tsx so content doesn't sit too far above the input bar.
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 95f98b7 May 10 2026, 09:05 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 95f98b7 Commit Preview URL

Branch Preview URL
May 10 2026, 09:06 PM

@claude
Copy link
Copy Markdown

claude Bot commented May 10, 2026

Claude finished @MaheshtheDev's task in 50s —— View job


Review Complete

  • Analyzing PR context
  • Reviewing diff for bugs, security issues, and logic errors
  • Checking surrounding code for boundary issues
  • Submitting review

Overview: Removes obsolete bottom padding from the mobile input bar (originally for a mobile nav that no longer exists) and adjusts scroll container padding to match.

Issues found: None — this looks good to ship.

The changes are straightforward CSS cleanup:

  1. page.tsx: Simplifies the input bar wrapper from conditional bottom-[4.5rem] (mobile) / bottom-0 (desktop) to just bottom-0 unconditionally
  2. dashboard-view.tsx: Reduces mobile scroll padding from pb-32 to pb-20 to compensate

The PR author has done thorough visual testing across 5 viewports confirming the input bar is flush with the viewport bottom on all sizes. Desktop behavior is explicitly unchanged (md:pb-36 padding preserved).

Score: 10/10

Clean removal of dead code with proper testing. No bugs, no security concerns, no breaking changes.

@ishaanxgupta ishaanxgupta merged commit 787fadf into main May 11, 2026
8 checks passed
vorflux Bot pushed a commit that referenced this pull request May 11, 2026
@graphite-app graphite-app Bot requested a review from Dhravya May 12, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants