Skip to content

feat(web): pwa prompt 'Add to Home Screen' opens share menu#963

Merged
graphite-app[bot] merged 1 commit into
mainfrom
mahesh/pwa-share-add-to-home
May 18, 2026
Merged

feat(web): pwa prompt 'Add to Home Screen' opens share menu#963
graphite-app[bot] merged 1 commit into
mainfrom
mahesh/pwa-share-add-to-home

Conversation

@MaheshtheDev
Copy link
Copy Markdown
Member

No description provided.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 18, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 52bd2b6 May 18 2026, 05:33 AM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 18, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 52bd2b6 Commit Preview URL

Branch Preview URL
May 18 2026, 05:34 AM

Copy link
Copy Markdown
Member Author


How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown

claude Bot commented May 18, 2026

Claude finished @MaheshtheDev's task in 1m 26s —— View job


Review Complete

  • Fetch PR diff and analyze changes
  • Read surrounding code for context
  • Check for existing review comments
  • Submit review

Summary: Clean implementation that opens the native share menu on iOS Safari when users tap "Add to Home Screen". The share sheet contains the actual "Add to Home Screen" option, improving the install UX. No bugs or security issues found.

Score: 9/10

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds a "Add to Home Screen" button on iOS that opens the native share menu, enabling users to add the PWA without manually navigating to the share sheet.

Issues found: None — this looks good to ship.

The implementation correctly:

  • Uses navigator.share() to open the native share sheet on iOS Safari
  • Falls back gracefully when Web Share API isn't available
  • Follows the existing pattern of dismissing the prompt after user interaction
  • The empty catch block is appropriate since share cancellation (AbortError) is expected behavior

The UX makes sense: on iOS Safari, the share sheet contains the "Add to Home Screen" option, so opening it directly helps guide users through the install flow.

Score: 9/10

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 18, 2026

Merge activity

@graphite-app graphite-app Bot force-pushed the mahesh/pwa-share-add-to-home branch from d355f13 to 52bd2b6 Compare May 18, 2026 05:32
@graphite-app graphite-app Bot merged commit 52bd2b6 into main May 18, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants