Skip to content

add team management in nova account settings#984

Merged
ved015 merged 6 commits into
mainfrom
ishaan/team
May 25, 2026
Merged

add team management in nova account settings#984
ved015 merged 6 commits into
mainfrom
ishaan/team

Conversation

@ishaanxgupta
Copy link
Copy Markdown
Contributor

@ishaanxgupta ishaanxgupta commented May 21, 2026

image image

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 21, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp a4601f1 May 24 2026, 08:30 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 21, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app a4601f1 Commit Preview URL

Branch Preview URL
May 24 2026, 08:31 PM

@ishaanxgupta ishaanxgupta marked this pull request as ready for review May 22, 2026 07:39
@graphite-app graphite-app Bot requested a review from Dhravya May 22, 2026 07:39
@claude
Copy link
Copy Markdown

claude Bot commented May 22, 2026

Claude finished @MaheshtheDev's task in 1m 21s —— View job


Review Complete

  • Fetch latest PR diff
  • Check for existing review comments
  • Analyze changes for bugs, security issues, and logic errors
  • Provide review summary

Overview: Adds team management functionality to Nova account settings, including member invitations, role updates, member removal, and invitation cancellation.

Issues found: None — this looks good to ship.

The implementation is solid:

  • Authorization: All mutations use authClient.organization.* methods with server-side validation. Client-side canManageTeam and isOwner checks appropriately gate UI, but actual authorization happens server-side.
  • Error handling: Consistent getErrorMessage helper extracts error messages with fallbacks, displayed via toasts.
  • Loading states: Submit buttons disable during pending mutations with loader icons.
  • Data sync: refetchActiveOrg properly awaits before showing success toasts, preventing stale UI.
  • Form behavior: Dialog prevents form reset if mutation is pending; validation correctly requires spaces for restricted access.
  • Role constraints: Cannot edit owners, cannot edit yourself, remove member restricted to owners only.

The latest commit (refactor(settings): align invite teammate modal with select-space house style) refines the UI styling without affecting logic.

Score: 9/10

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds team management functionality to Nova account settings, including member invitations, role updates, member removal, and invitation cancellation.

Issues found: None — this looks good to ship.

The implementation is solid:

  • Mutations properly use authClient.organization.* methods with server-side authorization
  • Consistent error handling via getErrorMessage helper with user-friendly toasts
  • Proper loading states and disabled conditions on interactive elements
  • Clean role-based UI gating (canManageTeam, isOwner)
  • refetchActiveOrg addition to auth context is minimal and correctly implemented

Score: 9/10

@ishaanxgupta ishaanxgupta marked this pull request as draft May 22, 2026 17:24
ved015 and others added 2 commits May 23, 2026 21:30
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ishaanxgupta ishaanxgupta marked this pull request as ready for review May 23, 2026 16:14
…se style

- match modal surface to select-spaces-modal (bg-#1B1F24, border-none, rounded-[22px], circular close)
- replace role chips with the same Select used in member rows
- move invite trigger to a button beside the Team members title; drop the standalone card
- swap navy fills for the neutral bg-#14161A + shadow-inside-out primary style
@ved015 ved015 merged commit ee9c579 into main May 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants