fix(npm): use native tar for Windows extraction, with PowerShell fallback#132
Merged
greynewell merged 2 commits intomainfrom Apr 15, 2026
Merged
fix(npm): use native tar for Windows extraction, with PowerShell fallback#132greynewell merged 2 commits intomainfrom
greynewell merged 2 commits intomainfrom
Conversation
…cleanup
- Extract extractZip() as a testable function with injectable execFn
- Move side-effectful module-level code inside require.main guard so
require('./install') no longer triggers a download
- Add try/finally to guarantee tmpDir cleanup even if copyFileSync throws
- Add 6 node:test tests covering tar path, PowerShell fallback, retry
loop structure, and path interpolation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review WalkthroughThe installation script now executes only when invoked directly (preventing side effects on import), and introduces a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up #131 with additional fixes and tests.
Changes:
tarfirst to extract the downloaded zip — avoids Antivirus file-lock crashes on Expand-ArchiveExpand-Archivewith a 10-attempt retry loop if tar failstry/finallyguaranteestmpDiris cleaned up even ifcopyFileSyncthrowsrequire.mainguard sorequire('./install')no longer triggers a downloadextractZip()as a testable function with injectableexecFnnode:testtests covering: tar path, PowerShell fallback, retry loop structure, path interpolation, and cleanupCloses #131
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Tests
Chores