fix: remove install-time setup wizard from install.sh#160
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughA new test file validates that Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 0/5 reviews remaining, refill in 11 minutes and 17 seconds. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@cmd/install_script_test.go`:
- Around line 18-27: The test currently uses brittle substrings; replace those
checks with token/regex-based assertions: in the "setup" test (the block that
references `" setup"` / `"supermodel setup"`) ensure you only fail when the
literal subcommand is invoked as a separate token (e.g., match word boundaries
for "supermodel setup" rather than any occurrence), and in the "includes
getting-started message" test (the t.Run block using variables lower,
hasRunSupermodel, hasGetStarted) detect the guidance robustly by matching
patterns like run supermodel with or without quotes and by checking for a
generic "get started" phrase using case-insensitive regex/strings functions;
update the hasRunSupermodel and hasGetStarted logic to use these token-aware
checks so harmless mentions don't break CI and valid guidance is accepted.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 638110d8-4353-49a3-bb1a-94335adab929
📒 Files selected for processing (1)
cmd/install_script_test.go
Address CodeRabbit review: replace brittle substring checks with regex-based assertions that match command execution shape (not arbitrary text mentions) and accept valid guidance variations case-insensitively. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
a40afdb to
9343939
Compare
Closes #153. Closes #158.
The install-time wizard runs in the wrong directory (wherever curl was run, not the user's project). Since bare
supermodelnow auto-launches setup (PR #152), the install.sh wizard call is redundant.TDD: added failing test first, implementing fix now.
🤖 Generated with Claude Code
Summary by CodeRabbit