Skip to content

fix: remove install-time setup wizard from install.sh#160

Merged
greynewell merged 3 commits intomainfrom
fix/remove-install-wizard
Apr 30, 2026
Merged

fix: remove install-time setup wizard from install.sh#160
greynewell merged 3 commits intomainfrom
fix/remove-install-wizard

Conversation

@greynewell
Copy link
Copy Markdown
Contributor

@greynewell greynewell commented Apr 30, 2026

Closes #153. Closes #158.

The install-time wizard runs in the wrong directory (wherever curl was run, not the user's project). Since bare supermodel now auto-launches setup (PR #152), the install.sh wizard call is redundant.

TDD: added failing test first, implementing fix now.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Added validation tests for the installation script to verify it provides users with appropriate getting-started instructions upon completion and maintains script integrity.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

Warning

Rate limit exceeded

@greynewell has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 17 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 25c02c0c-320a-4961-a1e4-b15139012011

📥 Commits

Reviewing files that changed from the base of the PR and between 1f7a093 and 9343939.

📒 Files selected for processing (2)
  • cmd/install_script_test.go
  • install.sh

Walkthrough

A new test file validates that install.sh meets two requirements: it must not invoke the setup wizard during installation, and it must instruct users to run supermodel to get started. The test loads and inspects the script content at test time using string matching.

Changes

Cohort / File(s) Summary
Install Script Validation Test
cmd/install_script_test.go
New test that loads install.sh and asserts it doesn't reference supermodel setup and contains a "run supermodel"/getting-started message.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • jonathanpopham

Poem

🧙‍♂️ The wizard once danced at install time's door,
Now it waits where projects live—the proper floor.
A test keeps watch, ensuring the script's right,
No setup at install, just "supermodel"—pure delight! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing the install-time setup wizard call from install.sh, which is the core objective of this PR.
Description check ✅ Passed The description references linked issues, explains the motivation, and mentions TDD approach, but lacks the formal test plan checklist from the template.
Linked Issues check ✅ Passed The PR adds a test validating two key requirements from issues #153 and #158: ensuring the wizard is removed and a getting-started message is present.
Out of Scope Changes check ✅ Passed The PR only adds a test file for install.sh validation; no implementation changes removing the wizard are included yet, which aligns with the TDD approach mentioned.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-install-wizard

Review rate limit: 0/5 reviews remaining, refill in 11 minutes and 17 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@cmd/install_script_test.go`:
- Around line 18-27: The test currently uses brittle substrings; replace those
checks with token/regex-based assertions: in the "setup" test (the block that
references `" setup"` / `"supermodel setup"`) ensure you only fail when the
literal subcommand is invoked as a separate token (e.g., match word boundaries
for "supermodel setup" rather than any occurrence), and in the "includes
getting-started message" test (the t.Run block using variables lower,
hasRunSupermodel, hasGetStarted) detect the guidance robustly by matching
patterns like run supermodel with or without quotes and by checking for a
generic "get started" phrase using case-insensitive regex/strings functions;
update the hasRunSupermodel and hasGetStarted logic to use these token-aware
checks so harmless mentions don't break CI and valid guidance is accepted.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 638110d8-4353-49a3-bb1a-94335adab929

📥 Commits

Reviewing files that changed from the base of the PR and between 037157d and 1f7a093.

📒 Files selected for processing (1)
  • cmd/install_script_test.go

Comment thread cmd/install_script_test.go Outdated
greynewell and others added 3 commits April 30, 2026 10:40
The wizard now auto-launches from bare 'supermodel' when run in a project
directory (PR #152). Running it at install time starts watch in the wrong
directory. Closes #153. Closes #158.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Address CodeRabbit review: replace brittle substring checks with
regex-based assertions that match command execution shape (not arbitrary
text mentions) and accept valid guidance variations case-insensitively.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@greynewell greynewell force-pushed the fix/remove-install-wizard branch from a40afdb to 9343939 Compare April 30, 2026 14:40
@greynewell greynewell marked this pull request as ready for review April 30, 2026 14:44
@greynewell greynewell merged commit c252e3f into main Apr 30, 2026
7 checks passed
@greynewell greynewell deleted the fix/remove-install-wizard branch April 30, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant