fix: metadata not updating for github + webhook replacement on setup#1907
Merged
forestileao merged 1 commit intomainfrom Jan 29, 2026
Merged
Conversation
Signed-off-by: Pedro Foresti Leão <pedroforestileao@gmail.com>
Deploying superplane with
|
| Latest commit: |
2057da2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a6f952cf.superplane.pages.dev |
| Branch Preview URL: | https://fix-github-onrelease-does-no.superplane.pages.dev |
forestileao
deleted the
fix/github.onRelease-does-not-update-metadata-list
branch
alabro-bm
pushed a commit
to alabro-bm/superplane
that referenced
this pull request
Jan 30, 2026
…uperplanehq#1907) ## Summary - Update GitHub trigger metadata when the configured repository changes (not only on first setup). - Replace mismatched webhooks by detaching the node and soft-deleting the old webhook when it’s no longer shared. - Add a unit test to verify webhook replacement behavior. ## Problem - Re-running GitHub `onRelease` setup did not update repository metadata when the repository changed. - Changing repository/configuration left old webhooks behind. ## Solution - `ensureRepoInMetadata` now updates metadata when the repository differs. - `RequestWebhook()` verifies an existing webhook’s configuration, detaches the node on mismatch, and soft-deletes the webhook if it’s not shared. - Added unit coverage for the replacement behavior. Closes: superplanehq#1801 Signed-off-by: Pedro Foresti Leão <pedroforestileao@gmail.com> Signed-off-by: alabro-bm <atanas.labroski@brightmarbles.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
onReleasesetup did not update repository metadata when the repository changed.Solution
ensureRepoInMetadatanow updates metadata when the repository differs.RequestWebhook()verifies an existing webhook’s configuration, detaches the node on mismatch, and soft-deletes the webhook if it’s not shared.Closes: #1801