feat: AWS CodeArtifact expansion - repos + package version operations#2944
Conversation
1410e3d to
023ec7d
Compare
web_src/src/pages/workflowv2/mappers/aws/codeartifact/delete_repository.ts
Show resolved
Hide resolved
|
@yinebebt thanks for submitting. The video looks good. Assigning @AleksandarCole to review the functinality. |
023ec7d to
3a8b3e1
Compare
- Add Create Repository and Delete Repository components. - Add Update Package Versions Status, Copy Package Versions, Delete Package Versions, and Dispose Package Versions. - Fix AWS error message formatting (double colon when Code is empty) - Downgrade "already being processed" log to Debug. - Docs: AWS.mdx, expansion plan, OIDC/tunnel setup; Makefile check target Signed-off-by: yinebebt <yintar5@gmail.com>
…test harness Signed-off-by: yinebebt <yintar5@gmail.com>
…egration id in serialization.go Signed-off-by: yinebebt <yintar5@gmail.com>
3a8b3e1 to
6254f14
Compare
web_src/src/pages/workflowv2/mappers/aws/codeartifact/delete_repository.ts
Show resolved
Hide resolved
Signed-off-by: Lucas Pinheiro <lucas@superplane.com>
|
@yinebebt everything looks good. Just doing a couple of touches, and will merge it shortly |
Signed-off-by: Lucas Pinheiro <lucas@superplane.com>
Signed-off-by: Lucas Pinheiro <lucas@superplane.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| } | ||
|
|
||
| return versions | ||
| } |
There was a problem hiding this comment.
Version parser ignores newline separators despite placeholder promise
Medium Severity
The parseVersionsList function only splits on commas, but the CopyPackageVersionsConfiguration.Versions field comment says "comma or newline separated" and the UI placeholder reads "1.0.0, 1.0.1 or one per line". If a user enters newline-separated versions, they'll be treated as a single version string (e.g., "1.0.0\n1.0.1"), which will fail when sent to the AWS API.
Additional Locations (2)
…superplanehq#2944) ## Summary Adds six AWS CodeArtifact components and fixes canvas save when a node references a removed integration. ## New components - **CodeArtifact • Create Repository** - Create a repository in a domain - **CodeArtifact • Delete Repository** - Delete a repository from a domain - **CodeArtifact • Update Package Versions Status** - Set version status (Archived / Published / Unlisted) - **CodeArtifact • Copy Package Versions** - Copy versions between repos in the same domain - **CodeArtifact • Delete Package Versions** - Permanently delete versions and assets - **CodeArtifact • Dispose Package Versions** - Delete assets and set status to Disposed ## Bug fixes - **AWS error formatting:** Avoid double colon in error messages when `Code` is empty; guard against nil integration in `CredentialsFromInstallation`. - **Logging:** “Already being processed” for queue items is now logged at Debug level. ## Docs and tooling - **docs/components/AWS.mdx** - All six CodeArtifact components documented - **docs/development/aws-codeartifact-expansion-plan.md** - Plan, manual testing notes, integration dropdown reminder - **docs/contributing/connecting-to-3rdparty-services-from-development.md** - AWS OIDC + tunnel setup and troubleshooting - **Makefile** - New `check` target (format.go, lint, check.build.app, format.js, check.build.ui) ## Testing - All six package operations tested manually (Create/Delete Repository; Update Status, Copy, Delete, Dispose Package Versions). - Demo video is uploaded off-GitHub due to file size: [Watch on Vimeo](https://vimeo.com/1162979840?share=copy&fl=sv&fe=ci). --- Closes superplanehq#2779 --------- Signed-off-by: yinebebt <yintar5@gmail.com> Signed-off-by: Lucas Pinheiro <lucas@superplane.com> Co-authored-by: Lucas Pinheiro <lucas@superplane.com> Signed-off-by: Aldo <aldo.abellto14@gmail.com>
…superplanehq#2944) ## Summary Adds six AWS CodeArtifact components and fixes canvas save when a node references a removed integration. ## New components - **CodeArtifact • Create Repository** - Create a repository in a domain - **CodeArtifact • Delete Repository** - Delete a repository from a domain - **CodeArtifact • Update Package Versions Status** - Set version status (Archived / Published / Unlisted) - **CodeArtifact • Copy Package Versions** - Copy versions between repos in the same domain - **CodeArtifact • Delete Package Versions** - Permanently delete versions and assets - **CodeArtifact • Dispose Package Versions** - Delete assets and set status to Disposed ## Bug fixes - **AWS error formatting:** Avoid double colon in error messages when `Code` is empty; guard against nil integration in `CredentialsFromInstallation`. - **Logging:** “Already being processed” for queue items is now logged at Debug level. ## Docs and tooling - **docs/components/AWS.mdx** - All six CodeArtifact components documented - **docs/development/aws-codeartifact-expansion-plan.md** - Plan, manual testing notes, integration dropdown reminder - **docs/contributing/connecting-to-3rdparty-services-from-development.md** - AWS OIDC + tunnel setup and troubleshooting - **Makefile** - New `check` target (format.go, lint, check.build.app, format.js, check.build.ui) ## Testing - All six package operations tested manually (Create/Delete Repository; Update Status, Copy, Delete, Dispose Package Versions). - Demo video is uploaded off-GitHub due to file size: [Watch on Vimeo](https://vimeo.com/1162979840?share=copy&fl=sv&fe=ci). --- Closes superplanehq#2779 --------- Signed-off-by: yinebebt <yintar5@gmail.com> Signed-off-by: Lucas Pinheiro <lucas@superplane.com> Co-authored-by: Lucas Pinheiro <lucas@superplane.com>
…superplanehq#2944) ## Summary Adds six AWS CodeArtifact components and fixes canvas save when a node references a removed integration. ## New components - **CodeArtifact • Create Repository** - Create a repository in a domain - **CodeArtifact • Delete Repository** - Delete a repository from a domain - **CodeArtifact • Update Package Versions Status** - Set version status (Archived / Published / Unlisted) - **CodeArtifact • Copy Package Versions** - Copy versions between repos in the same domain - **CodeArtifact • Delete Package Versions** - Permanently delete versions and assets - **CodeArtifact • Dispose Package Versions** - Delete assets and set status to Disposed ## Bug fixes - **AWS error formatting:** Avoid double colon in error messages when `Code` is empty; guard against nil integration in `CredentialsFromInstallation`. - **Logging:** “Already being processed” for queue items is now logged at Debug level. ## Docs and tooling - **docs/components/AWS.mdx** - All six CodeArtifact components documented - **docs/development/aws-codeartifact-expansion-plan.md** - Plan, manual testing notes, integration dropdown reminder - **docs/contributing/connecting-to-3rdparty-services-from-development.md** - AWS OIDC + tunnel setup and troubleshooting - **Makefile** - New `check` target (format.go, lint, check.build.app, format.js, check.build.ui) ## Testing - All six package operations tested manually (Create/Delete Repository; Update Status, Copy, Delete, Dispose Package Versions). - Demo video is uploaded off-GitHub due to file size: [Watch on Vimeo](https://vimeo.com/1162979840?share=copy&fl=sv&fe=ci). --- Closes superplanehq#2779 --------- Signed-off-by: yinebebt <yintar5@gmail.com> Signed-off-by: Lucas Pinheiro <lucas@superplane.com> Co-authored-by: Lucas Pinheiro <lucas@superplane.com> Signed-off-by: Muhammad Fuzail Zubari <mfuzail.zubari@gmail.com>
…superplanehq#2944) ## Summary Adds six AWS CodeArtifact components and fixes canvas save when a node references a removed integration. ## New components - **CodeArtifact • Create Repository** - Create a repository in a domain - **CodeArtifact • Delete Repository** - Delete a repository from a domain - **CodeArtifact • Update Package Versions Status** - Set version status (Archived / Published / Unlisted) - **CodeArtifact • Copy Package Versions** - Copy versions between repos in the same domain - **CodeArtifact • Delete Package Versions** - Permanently delete versions and assets - **CodeArtifact • Dispose Package Versions** - Delete assets and set status to Disposed ## Bug fixes - **AWS error formatting:** Avoid double colon in error messages when `Code` is empty; guard against nil integration in `CredentialsFromInstallation`. - **Logging:** “Already being processed” for queue items is now logged at Debug level. ## Docs and tooling - **docs/components/AWS.mdx** - All six CodeArtifact components documented - **docs/development/aws-codeartifact-expansion-plan.md** - Plan, manual testing notes, integration dropdown reminder - **docs/contributing/connecting-to-3rdparty-services-from-development.md** - AWS OIDC + tunnel setup and troubleshooting - **Makefile** - New `check` target (format.go, lint, check.build.app, format.js, check.build.ui) ## Testing - All six package operations tested manually (Create/Delete Repository; Update Status, Copy, Delete, Dispose Package Versions). - Demo video is uploaded off-GitHub due to file size: [Watch on Vimeo](https://vimeo.com/1162979840?share=copy&fl=sv&fe=ci). --- Closes superplanehq#2779 --------- Signed-off-by: yinebebt <yintar5@gmail.com> Signed-off-by: Lucas Pinheiro <lucas@superplane.com> Co-authored-by: Lucas Pinheiro <lucas@superplane.com> Signed-off-by: Muhammad Fuzail Zubari <mfuzail.zubari@gmail.com>


Summary
Adds six AWS CodeArtifact components and fixes canvas save when a node references a removed integration.
New components
Bug fixes
Codeis empty; guard against nil integration inCredentialsFromInstallation.Docs and tooling
checktarget (format.go, lint, check.build.app, format.js, check.build.ui)Testing
Closes #2779