feat: Add Create & Delete Hetzner Load Balancer integrations #3169
feat: Add Create & Delete Hetzner Load Balancer integrations #3169shiroyasha merged 3 commits intosuperplanehq:mainfrom
Conversation
3fc3937 to
289c77b
Compare
289c77b to
cd26cee
Compare
cd26cee to
f724f2a
Compare
|
@usernamenenad looks good. What remains: 1/ that one comment from cursor |
Signed-off-by: usernamenenad <radovic.nenad158@gmail.com>
Signed-off-by: usernamenenad <radovic.nenad158@gmail.com>
f724f2a to
86090be
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| type createLoadBalancerResponse struct { | ||
| LoadBalancer *ServerResponse `json:"load_balancer"` | ||
| Action *ActionResponse `json:"action"` | ||
| } |
There was a problem hiding this comment.
Response struct uses wrong JSON key for actions
High Severity
The createLoadBalancerResponse struct maps Action to JSON field "action" (singular), but the Hetzner Cloud API's POST /load_balancers endpoint returns "actions" (plural array). This means out.Action will always be nil after deserialization via decodeJSON, causing the nil check to always fail and CreateLoadBalancer to always return the error "create load balancer missing load_balancer or action". The entire Create Load Balancer feature is broken.
Additional Locations (1)
There was a problem hiding this comment.
No, the official documentation says that it returns a singular word (action)
https://docs.hetzner.cloud/reference/cloud#tag/load-balancers/create_load_balancer


(There is no ticket for this - idk if I should make it?)
This PR adds Create and Delete Hetzner Load Balancer integrations to Superplane.
There are abilities to choose load balancer type, its' location and load balancing algorithm.
Delete Load Balancer configuration lists available load balancers to be deleted.