feat(cli): add connection spinner for tool commands#89
Merged
Conversation
Add a loading spinner during MCP server connection for tool info,
tool call, and tool run commands. This provides visual feedback when
servers take time to start (e.g., downloading dependencies).
- Show spinner in human-readable mode only (not json/concise)
- Display "Connecting to {tool_name}..." while connecting
- Clear spinner on success, show failure indicator on error
- Replace verbose-only message in tool run with always-on spinner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
lib/handlers/tool/info.rs: Added Spinner import and wrappedget_tool_info()call with spinner that shows "Connecting to {tool_name}..." in human-readable modelib/handlers/tool/call.rs: Added Spinner import and wrappedcall_tool()call with spinner that shows "Connecting to {tool_name}..." in human-readable modelib/handlers/tool/run.rs: Replaced verbose-only "Connecting to backend MCP server..." message with an always-on spinnerspinner.fail()before displaying error messagesspinner.done()to clear the spinner cleanlyTest Plan
tool info <tool>and verify spinner displays while connectingtool call <tool> -m <method>and verify spinner displays while connectingtool run <tool>and verify spinner displays while connecting--jsonflag to verify no spinner appears--conciseflag to verify no spinner appears