feat: added Json flag to allow more native type usage #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of a uint8 array"
John-Memphis
requested review from
daniel-davidd,
idanasulin2706 and
shay23b
as code owners
idanasulin2706
requested changes
Dec 10, 2023
| event, | ||
| event_handler: callable, | ||
| use_async: bool = False | ||
| use_async: bool = False, |
Contributor
There was a problem hiding this comment.
readme is missing, and make sure the user should not handle the json in the return statement as well. Like mentioned in the Nodejs comments
Contributor
Author
There was a problem hiding this comment.
readme was missing, fixed that, and then the as_json I renamed to as_dict because that's more pythonic I think.
Function was already doing the conversion for the user, just wasn't documented (for both repos).
idanasulin2706
approved these changes
Dec 11, 2023
idanasulin2706
added a commit
that referenced
this pull request
Dec 11, 2023
* add * Update README.md * Update README.md * feat: Added asyncio support (#3) * feat: added Json flag to allow more native type usage (#4) * "Added as_json flag" * "When as_json is given, allows the return of a javascript object instead of a uint8 array" * "Updated Readme, changed as_json to as_dict" * fixes * version --------- Co-authored-by: idanasulinStrech <idan@memphis.dev> --------- Co-authored-by: valeraBr <valera@memphis.dev> Co-authored-by: Valera Bronshtein <105710429+valeraBr@users.noreply.github.com> Co-authored-by: Yaniv Ben Hemo <70286779+yanivbh1@users.noreply.github.com> Co-authored-by: Avitaltrifsik <107035359+Avitaltrifsik@users.noreply.github.com> Co-authored-by: John-Memphis <136013599+John-Memphis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.