Fetch messages #116
Merged
Fetch messages #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| internal_station_name = get_internal_name(station_name) | ||
| consumer_map_key = internal_station_name + "_" + consumer_name.lower() | ||
| if consumer_map_key in self.consumers_map: | ||
| consumer = self.consumers_map[consumer_map_key] |
Contributor
There was a problem hiding this comment.
in this case please update the batch size otherwise it will be the first one
| start_consume_from_sequence: int = 1, | ||
| last_messages: int = -1 | ||
| ): | ||
| try: |
Contributor
There was a problem hiding this comment.
missing description
idanasulin2706
previously approved these changes
Feb 27, 2023
idanasulin2706
approved these changes
Feb 28, 2023
idanasulin2706
added a commit
that referenced
this pull request
Mar 16, 2023
* Update README.md (#115) * Fetch messages (#116) * add fetch_messages function * try fetch dls * fetch messages + fetch dls messages * bug fix + erase on close/destroy * enable change batch size on same consumer in fetch * add readme for consumer.fetch() * allow change batch size in existing consumer * refactor storage and retention variables to be enum based (#118) * Feature/file modularity (#119) * refactor storage and retention variables to be enum based * separated memphis.py big file into multiple logical files for better tracking and maintaincing of code * fix imports (#121) * adding explanation about retention values (#122) * delete station (#124) * delete station * fix issues * add comment * Fix formatting error (#125) A backtack was missing in one of the Markdown code blocks, causing the code snippet to fail to render. * change MAINTAINERS.md file (#126) Co-authored-by: ido <ido@ip-192-168-1-114.eu-central-1.compute.internal> * Update README.md * update version --------- Co-authored-by: Avitaltrifsik <107035359+Avitaltrifsik@users.noreply.github.com> Co-authored-by: Shay Bratslavsky <shay@memphis.dev> Co-authored-by: Alon David <37884564+alon-david@users.noreply.github.com> Co-authored-by: Bruno Bandeira <brunoban.dev@gmail.com> Co-authored-by: shohamroditimemphis <108217318+shohamroditimemphis@users.noreply.github.com> Co-authored-by: RJ Nowling <rnowling@gmail.com> Co-authored-by: idonaaman123 <127736311+idonaaman123@users.noreply.github.com> Co-authored-by: ido <ido@ip-192-168-1-114.eu-central-1.compute.internal>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.