Skip to content

Conversation

@ItsVigneshMurugan
Copy link
Contributor

@ItsVigneshMurugan ItsVigneshMurugan commented Jul 27, 2023

Related to superstreamlabs/memphis#1107

I've used https://github.com/fastavro/fastavro instead of https://github.com/apache/avro because of it's performance.

@idanasulin2706
Copy link
Contributor

Looks great @Big-Vi, will be merged once we will merge the broker PR

Copy link
Contributor

@idanasulin2706 idanasulin2706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Big-Vi big thank you for this amazing contribution, approved.
Before merging just please resolve the lint issues

@ItsVigneshMurugan
Copy link
Contributor Author

@Big-Vi big thank you for this amazing contribution, approved. Before merging just please resolve the lint issues

Resolved. Thanks.

@rnowling-memphis rnowling-memphis merged commit 3bdbac4 into superstreamlabs:master Jul 31, 2023
@rnowling-memphis
Copy link
Contributor

@Big-Vi Fantastic work! I merged your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants