Bug fixes + restructure#31
Merged
Merged
Conversation
1. Fixed table iteration bug in favorites removal (lines 1469-1515):
- Using table.remove() inside pairs() loop caused iteration skipping
- Changed to iterate backwards from #table to 1, which is safe for removal
- Affects all 8 favorite categories (items, itemsets, spells, skills,
quests, creatures, objects, teles)
2. Fixed incorrect string.gmatch usage in teleport filtering (line 840):
- string.gmatch() returns iterator, not boolean - condition was always true
- Changed to string.find() which correctly returns nil when not found
- Fixes broken teleport message hiding logic
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Fixed critical bugs in MangFrames_SectionServer.lua (lines 369-383): 1. Added nil check for delayParam before comparison: - tonumber() returns nil for non-numeric input - Prevents "attempt to compare number with nil" error 2. Added nil check for diff value before using in graph: - Prevents crash when ma_difftext contains non-numeric text - Wraps comparison and AddBar calls in nil check These bugs caused error spam in the OnUpdate loop which could freeze the UI. Both issues are now prevented with proper nil validation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Created new directory structure (Core, Data, Modules folders) - Moved data files (DBC.lua, Models.lua, TeleportTable.lua) to Data/ - Moved core files to Core/ (AzerothAdmin.lua, Init.lua) - Moved MangLinkifier.lua to Modules/Linkifier.lua - Moved MangFrames.lua to Frames/ - Renamed all Commands files to remove "Commands_" prefix - Updated AzerothAdmin.toc with new file paths - Removed reference to non-existent Commands_Log.lua from .toc This improves code organization and maintainability by grouping related files into logical directories following WoW addon best practices. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Restructure to BugFixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected a few additional bugs found during testing and refactored folder structure for better addon layout