feat: user management support API types#944
Draft
deepjyoti30-st wants to merge 12 commits into21.0from
Draft
Conversation
Deploying supertokens-node-pr-check-for-edge-function-compat with
|
| Latest commit: |
ed648ed
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f0a1ab0.supertokens-node-b95.pages.dev |
rishabhpoddar
suggested changes
Oct 14, 2024
| @@ -325,6 +325,40 @@ export type APIInterface = { | |||
| } | |||
| | GeneralErrorResponse | |||
| >); | |||
Contributor
There was a problem hiding this comment.
try out (emailverification in required mode, and account linking switched on):
- First factor is passwordless -> login with email A, then call the signUpPOST API with email A and some password and the access token of the session. See what happens.
- First factor is passwordless -> login with email A, mark email A as unverified, then call the signUpPOST API with email A and some password and the access token of the session. See what happens.
Contributor
There was a problem hiding this comment.
This API can be called when setting a password for an existing account that has no email password login method.
lib/ts/recipe/emailpassword/types.ts
Outdated
| newPassword: string; | ||
| oldPassword?: string; | ||
| }; | ||
| session: SessionContainerInterface; |
Contributor
There was a problem hiding this comment.
session verification here should not have overrideGlobalClaimValidators: () => [] in our api implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of change
This PR defines the types for API interface for user management related functionality.
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)lib/ts/version.tsfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)package.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettyrecipe/thirdparty/providers/configUtils.tsfile,createProviderfunction.git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.add-ts-no-check.jsfile to include thatsomeFunc: function () {..}).exportsinpackage.json