Skip to content

feat: Define TOTP recipe plugin interface #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Mar 27, 2023
Merged

feat: Define TOTP recipe plugin interface #53

merged 22 commits into from
Mar 27, 2023

Conversation

@KShivendu
Copy link
Contributor

@KShivendu KShivendu commented Feb 6, 2023 •
edited
Loading

Summary of change

Define TOTP recipe plugin interface

Related issues

Checklist for important updates

  • Changelog has been updated
  • Changes to the version if needed
    • In build.gradle
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

rishabhpoddar
rishabhpoddar suggested changes Feb 8, 2023
View reviewed changes
rishabhpoddar
rishabhpoddar suggested changes Feb 9, 2023
View reviewed changes
rishabhpoddar
rishabhpoddar suggested changes Feb 11, 2023
View reviewed changes
rishabhpoddar
rishabhpoddar suggested changes Feb 23, 2023
View reviewed changes
@KShivendu
feat: Improve TOTP interface
2a172be 
- Split device deletion into SQL transactions
- Improve variables and return types
- Make the storage to return all used codes
rishabhpoddar
rishabhpoddar suggested changes Feb 28, 2023
View reviewed changes
@rishabhpoddar rishabhpoddar marked this pull request as draft February 28, 2023 15:48
@rishabhpoddar rishabhpoddar changed the base branch from 2.19 to 2.20 March 3, 2023 08:19
KShivendu added 2 commits March 7, 2023 19:14
@KShivendu
feat: Improved TOTP interface
8cec416 
These changes will support the following features in the core:
- Remove expired codes only after cooldown
- Allow retries while inserting used codes
@KShivendu
refactor: insertUsedCode and getAllusedCodes should be part of a tran…
ba5c2ef 
…saction
@KShivendu
feat: Add plugin interface for active users storage layer (#62)
f422126 
* feat: Add plugin interface for active users storage layer

* chores: Mention active users storage interface in CHANGELOG

* refactor: Throw error in storage Layer and later suppress them directly in API layer
@KShivendu
feat: Add more methods to active user storage interface for usage stats
f9d54b0
@rishabhpoddar rishabhpoddar changed the base branch from 2.20 to 2.21 March 27, 2023 13:50
@rishabhpoddar rishabhpoddar marked this pull request as ready for review March 27, 2023 13:50
@rishabhpoddar rishabhpoddar merged commit 61a12de into 2.21 Mar 27, 2023
@rishabhpoddar rishabhpoddar deleted the feat/totp-plugin-interface branch March 27, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rishabhpoddar rishabhpoddar rishabhpoddar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KShivendu @rishabhpoddar