feat: Add plugin interface for active users storage layer #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhpoddar
approved these changes
Mar 21, 2023
rishabhpoddar
pushed a commit
that referenced
this pull request
Mar 27, 2023
* feat: Define TOTP recipe plugin interface * fix: Improve TOTPStorage * fix: Changes to TOTPStorage * chores: Mention TOTP recipe in CHANGELOG * fix(totp): Inherit from Exception instead of EmailPasswordException * fix: Remove TotpNotEnabledException wherever its not possible to throw it * fix: Update the order of init params for TOTPDevice * feat: Add optional deviceName to TOTPUsedCode * refactor: markDevicesAsVerified should return boolean * feat: Introduce equals for clean comparison in tests and rename getUsedCodes for clarity * feat: Add javadocs for TOTPStorage and createdTime for TOTPUsedCode * feat: Add method to delete all the data for user * refactor: Improve interfaces and javadocs * feat: Improve TOTP interface - Split device deletion into SQL transactions - Improve variables and return types - Make the storage to return all used codes * refactor: Remove deleteAllTotpDataForUser of TOTPStorage * refactor: Update getAllUsedCodes method name * feat: Improved TOTP interface These changes will support the following features in the core: - Remove expired codes only after cooldown - Allow retries while inserting used codes * refactor: insertUsedCode and getAllusedCodes should be part of a transaction * refactor: Improve TOTP related transactions * feat: Add plugin interface for active users storage layer (#62) * feat: Add plugin interface for active users storage layer * chores: Mention active users storage interface in CHANGELOG * refactor: Throw error in storage Layer and later suppress them directly in API layer * feat: Add more methods to active user storage interface for usage stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Add plugin interface for active users storage layer
Related issues
Checklist for important updates
build.gradlegit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.