Skip to content

Comments

[WIP] Fix release.yml to include built binaries#35

Merged
supervoidcoder merged 3 commits intomainfrom
copilot/fix-release-yml-binaries
Jan 19, 2026
Merged

[WIP] Fix release.yml to include built binaries#35
supervoidcoder merged 3 commits intomainfrom
copilot/fix-release-yml-binaries

Conversation

Copy link
Contributor

Copilot AI commented Jan 19, 2026

Fix release.yml to include built binaries in GitHub releases

Analysis

  • Identified the issue: The release.yml workflow downloads artifacts successfully but fails to upload them to GitHub releases
  • Confirmed v0.1.1 release exists but has no assets attached
  • Located the problem: The files parameter in the softprops/action-gh-release@v2 action (lines 301-304)

Implementation

  • Changed the files parameter from multiline literal paths to a glob pattern artifacts/**/*.exe
  • This ensures all .exe files in the artifacts directory are uploaded to the release
  • Reduced code from 4 lines to 1 line, making it more maintainable

Testing & Validation

  • Code review passed with no issues
  • Security scan (CodeQL) passed with no alerts
  • Change is minimal and targeted (3 lines removed, 1 line added)
  • Ready to merge
Original prompt

This section details on the original issue you should resolve

<issue_title>release.yml doesn't include built binaries</issue_title>
<issue_description>2026-01-19T20:17:29.5160286Z Current runner version: '2.331.0'
2026-01-19T20:17:29.5190981Z ##[group]Runner Image Provisioner
2026-01-19T20:17:29.5192077Z Hosted Compute Agent
2026-01-19T20:17:29.5193200Z Version: 20251211.462
2026-01-19T20:17:29.5194329Z Commit: 6cbad8c2bb55d58165063d031ccabf57e2d2db61
2026-01-19T20:17:29.5195400Z Build Date: 2025-12-11T16:28:49Z
2026-01-19T20:17:29.5196416Z Worker ID: {a2231b86-0d03-4602-b9c5-3472979f6c06}
2026-01-19T20:17:29.5197559Z ##[endgroup]
2026-01-19T20:17:29.5198377Z ##[group]Operating System
2026-01-19T20:17:29.5199192Z Ubuntu
2026-01-19T20:17:29.5200072Z 24.04.3
2026-01-19T20:17:29.5200768Z LTS
2026-01-19T20:17:29.5201481Z ##[endgroup]
2026-01-19T20:17:29.5202246Z ##[group]Runner Image
2026-01-19T20:17:29.5203350Z Image: ubuntu-24.04
2026-01-19T20:17:29.5204174Z Version: 20260111.209.1
2026-01-19T20:17:29.5205977Z Included Software: https://github.com/actions/runner-images/blob/ubuntu24/20260111.209/images/ubuntu/Ubuntu2404-Readme.md
2026-01-19T20:17:29.5208554Z Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu24%2F20260111.209
2026-01-19T20:17:29.5210250Z ##[endgroup]
2026-01-19T20:17:29.5212107Z ##[group]GITHUB_TOKEN Permissions
2026-01-19T20:17:29.5214856Z Actions: write
2026-01-19T20:17:29.5215690Z Checks: write
2026-01-19T20:17:29.5216433Z Contents: write
2026-01-19T20:17:29.5217336Z Metadata: read
2026-01-19T20:17:29.5218125Z ##[endgroup]
2026-01-19T20:17:29.5220792Z Secret source: Actions
2026-01-19T20:17:29.5221999Z Prepare workflow directory
2026-01-19T20:17:29.5668431Z Prepare all required actions
2026-01-19T20:17:29.5723218Z Getting action download info
2026-01-19T20:17:29.8629650Z Download action repository 'actions/download-artifact@v4' (SHA:d3f86a106a0bac45b974a628896c90dbdf5c8093)
2026-01-19T20:17:30.1634182Z Download action repository 'actions/checkout@v4' (SHA:34e114876b0b11c390a56381ad16ebd13914f8d5)
2026-01-19T20:17:30.1974053Z Download action repository 'softprops/action-gh-release@v2' (SHA:a06a81a03ee405af7f2048a818ed3f03bbf83c7b)
2026-01-19T20:17:30.4678416Z Complete job name: Create GitHub Release with all artifacts
2026-01-19T20:17:30.5358842Z ##[group]Run actions/download-artifact@v4
2026-01-19T20:17:30.5359784Z with:
2026-01-19T20:17:30.5360220Z path: artifacts
2026-01-19T20:17:30.5360670Z merge-multiple: false
2026-01-19T20:17:30.5361166Z repository: supervoidcoder/win-witr
2026-01-19T20:17:30.5361690Z run-id: 21150353268
2026-01-19T20:17:30.5362479Z ##[endgroup]
2026-01-19T20:17:30.8350462Z Found 3 artifact(s)
2026-01-19T20:17:30.8353301Z No input name, artifact-ids or pattern filtered specified, downloading all artifacts
2026-01-19T20:17:30.8355852Z An extra directory with the artifact name will be created for each download
2026-01-19T20:17:30.8357941Z Preparing to download the following artifacts:
2026-01-19T20:17:30.8361045Z - win-witr-arm64 (ID: 5181672758, Size: 131536, Expected Digest: sha256:b5e83a9e993e73c753e27e05deb4c920bdfc065f464a25feb1a07603518269e0)
2026-01-19T20:17:30.8366413Z - win-witr-x86 (ID: 5181668369, Size: 132512, Expected Digest: sha256:9a105cab1dea692f77ea1e54b50d0959dc1455addc7f149790a0f8b5e8b16c64)
2026-01-19T20:17:30.8371780Z - win-witr-x64 (ID: 5181668280, Size: 157088, Expected Digest: sha256:d9447bd70f6fdeaffac2afb7e1fe8dacd3f120481157cd4afbd551776604f586)
2026-01-19T20:17:30.9108275Z Redirecting to blob download url: https://productionresultssa8.blob.core.windows.net/actions-results/6a64ee60-c774-47ab-9f89-272fdb9e8dd7/workflow-job-run-52e83cc6-b358-5565-922d-f5af1f831f77/artifacts/041827ec85a4826b18b847846654029b69630f88e28a38160ed99c84808859c8.zip
2026-01-19T20:17:30.9114912Z Starting download of artifact to: /home/runner/work/win-witr/win-witr/artifacts/win-witr-x64
2026-01-19T20:17:30.9139577Z Redirecting to blob download url: https://productionresultssa8.blob.core.windows.net/actions-results/6a64ee60-c774-47ab-9f89-272fdb9e8dd7/workflow-job-run-62a85d21-118e-5c9c-b178-36cb1451f461/artifacts/bc1444524316bfcfcb5693979cd213a87a702dcbaae089bbc09bb123318c3da6.zip
2026-01-19T20:17:30.9146178Z Starting download of artifact to: /home/runner/work/win-witr/win-witr/artifacts/win-witr-arm64
2026-01-19T20:17:30.9199763Z Redirecting to blob download url: https://productionresultssa8.blob.core.windows.net/actions-results/6a64ee60-c774-47ab-9f89-272fdb9e8dd7/workflow-job-run-ccbaac69-b489-5541-bcb0-7e6e177a1d5d/artifacts/58c87638686190cb0b2daa4c7a5f56f2c3e9847eaa1ce6dc8b2ea25c5943a648.zip
2026-01-19T20:17:30.9208393Z Starting download of artifact to: /home/runner/work/win-witr/win-witr/artifacts/win-witr-x86
2026-01-19T20:17:30.9617101Z (node:2010) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods ins...


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 19, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI and others added 2 commits January 19, 2026 20:22
Co-authored-by: supervoidcoder <88671013+supervoidcoder@users.noreply.github.com>
@supervoidcoder supervoidcoder marked this pull request as ready for review January 19, 2026 20:25
@supervoidcoder supervoidcoder merged commit 9d2c015 into main Jan 19, 2026
6 checks passed
Copilot AI requested a review from supervoidcoder January 19, 2026 20:25
Copilot stopped work on behalf of supervoidcoder due to an error January 19, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

release.yml doesn't include built binaries

2 participants