Conversation
- Now we only return true for deep linking if it will definitely be handled by Superwall. There could still be a case where the function returns false but then goes onto handle a deep link if config hasn't been retrieved before. Also if the deep link has been removed in an updated config it could falsely return true. But these are edge cases - Adds tests for deep linking
Now matches the logic of the deep link handling function
… only when internal
feat: add iframe navigation feature flag
feat: user attribute setting
…ition fix crash in SwiftyJSON dictionary unwrap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Enhancements
Set user attributesaction.SuperwallDelegatemethod calleduserAttributesDidChangethat notifies you when user attributes change from an external source.Fixes
PurchaseResultfromSuperwall.shared.purchase(_:)when using StoreKit 1 inside aPurchaseController.handleDeepLinkreturning true for non-Superwall URLs when called before configuration completes.Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.swiftlintin the main directory and fixed any issues.