chore: use prefer-lowest instead of prefer-stable #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytestream
changed the title
bytestream
changed the title
Member
Author
|
Any thoughts on this @Gaitholabi ? I think we just have to suck it up and fix PHPStan issues as they arise. I'm not sure that this PR is the way forward. |
Collaborator
Yeah I think so too, it's better to have things compatible and fix them rather than ignoring them and using old dependencies. |
Member
Author
|
OK I will close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're receiving inconsistent CI results without actually changing anything, evident in:
This is due to the use of
--prefer-stablewhen runningcomposer updateto install dependencies for each PHP version.In the case of the referenced PRs
symfony/dependency-injectionchanged a docblock frommixedtostring|[..]- see:This then causes PHPStan to complain that the return type is no longer
stringit can be anything.