Skip to content

Conversation

@fopina
Copy link
Contributor

@fopina fopina commented Feb 5, 2023

I was unable to list tables in my app and once I started looking into this, there were 3 different things:

  • NoTable was not supported in django-admin - an exception was thrown due to non-existing field (size)
  • After adding size, it still wasn't working (maybe it never did?) because it actually tried to query a non-existing table - now added a custom manager to always return none queryset
  • There's a different ENGINE also supported for psycopg2 and those using it would end up with NoTable - added it to the list

Also updated the workflows

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023

Codecov Report

Base: 85.11% // Head: 85.35% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (c14649c) compared to base (f35239a).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   85.11%   85.35%   +0.23%     
==========================================
  Files           6        6              
  Lines         309      314       +5     
==========================================
+ Hits          263      268       +5     
  Misses         46       46              
Impacted Files Coverage Δ
dbcleanup/models.py 95.23% <100.00%> (+0.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fopina fopina requested a review from gsilvapt February 6, 2023 00:33
Co-authored-by: Gustavo Silva <gustavosantaremsilva@gmail.com>
Signed-off-by: Filipe Pina <636320+fopina@users.noreply.github.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gsilvapt gsilvapt merged commit a1ae34e into main Feb 6, 2023
@gsilvapt gsilvapt deleted the fix/pg_dburl branch February 6, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants