Implement semver tags in CI/CD workflows#76
Closed
gsilvapt wants to merge 3 commits intosurface-security:mainfrom
gsilvapt:main
Closed
Implement semver tags in CI/CD workflows#76gsilvapt wants to merge 3 commits intosurface-security:mainfrom gsilvapt:main
gsilvapt wants to merge 3 commits intosurface-security:mainfrom
gsilvapt:main
Conversation
misc: refactor actions
- Remove unused `-dev` workflows.
- Rename files for better readability
- Changes workflows so that:
- Each PR will take the highest tag from `git` and increment a patch
level, a runner id, and a `-dev` after it, so that no image can be the same.
- To publish a new artifact, a new tag has to be pushed.
Contributor
Author
|
Superseded by #77 because this PR comes from a fork a the tokens are misbehaving (which kind of makes sense). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ultimate purpose of this PR is to convert the current CI/CD workflows to leverage
gittags. For dev builds, it will take the latest one, increment a patch level and append-devand the runner id. The final build, that only runs when a new tag is created, uses the tag that triggered the workflow to build the temporary image and publish that one. Added a default to use 1.0.0 if there's no tag created. If this PR gets approved, creating 1.0.0 should solve this and things should go along just fine.To view the workflow running, check my fork:
In addition, since I was on it, I moved some files around, renamed others and tried to make things more easy to work with (no offense 🙏 ).