Skip to content

Allow ranges to be passed for :list props #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 2, 2021
Merged

Allow ranges to be passed for :list props #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
33bbe94
Allow ranges to be passed for :list props
davydog187 Apr 30, 2021
dbbb160
fix!
davydog187 May 2, 2021
26654a7
cast to list
davydog187 May 2, 2021
6d238b3
cast to list tests
davydog187 May 2, 2021
2531542
formatting
davydog187 May 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/surface/type_handler/list.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ defmodule Surface.TypeHandler.List do
defp handle_list_expr(name, expr) do
quote generated: true do
case unquote(expr) do
value when is_list(value) ->
value
value when is_list(value) or is_struct(value, Range) ->
Enum.to_list(value)

value ->
raise "invalid value for property \"#{unquote(name)}\". Expected a :list, got: #{
Expand Down
14 changes: 14 additions & 0 deletions test/properties_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,20 @@ defmodule Surface.PropertiesTest do
"""
end

test "passing a range" do
html =
render_surface do
~H"""
<ListProp prop={1..3}/>
"""
end

assert html =~ """
List?: true
<span>value: 1</span><span>value: 2</span><span>value: 3</span>
"""
end

test "passing a keyword list without brackets" do
html =
render_surface do
Expand Down