Disable practice mode when player touches a map/bonus start zone.#321
Merged
dPexxIAM merged 1 commit intosurftimer:masterfrom Sep 28, 2021
1zc:saveloc-patch
Merged
Disable practice mode when player touches a map/bonus start zone.#321dPexxIAM merged 1 commit intosurftimer:masterfrom 1zc:saveloc-patch
dPexxIAM merged 1 commit intosurftimer:masterfrom
1zc:saveloc-patch
Conversation
Kyli3Boi
pushed a commit
to Kyli3Boi/Surftimer-Official
that referenced
this pull request
Sep 28, 2021
Kyli3Boi
pushed a commit
to Kyli3Boi/Surftimer-Official
that referenced
this pull request
Sep 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the timer disables Practice Mode for a player only when they exit the start zone. This has left room for an exploit in the current release that allows players to bypass limitations placed in the start-zone as a result of still being in Practice Mode after failing.
Since
g_bPracticeMode[client]is still true when a player is in the start-zone after failing, they can bypass the prespeed limiter and prehop infinitely to give themselves a massive advantage. (i.e, players can enter practice mode, fail by hitting a reset trigger, and then prehop infinitely in the start zone.)This pull request turns off Practice Mode for a player when they enter a start zone rather than when they exit one. This prevents the above exploit from being possible.