Excluding "effectively elastic" neutron scattering reactions#243
Merged
gonuke merged 1 commit intosvalinn:mainfrom Mar 3, 2026
Merged
Excluding "effectively elastic" neutron scattering reactions#243gonuke merged 1 commit intosvalinn:mainfrom
gonuke merged 1 commit intosvalinn:mainfrom
Conversation
gonuke
approved these changes
Mar 3, 2026
Member
gonuke
left a comment
gonuke
left a comment
There was a problem hiding this comment.
This looks clear - thanks @eitan-weinstein
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Independent of #229.
This PR prevents the writing of reactions in which the parent and daughter are the same out to the DSV for ALARAJOYWrapper. As it stands, MT = 2 (elastic neutron scattering) is already excluded, but because we have processing to force isomers lacking decay data to ground, those reactions are effectively creating new pathways for elastic scattering. To reduce the size of the processed DSV file (and subsequent tree files), these reactions can be excluded entirely.