Skip to content

fix: remove unused promise #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2025
Merged

fix: remove unused promise #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b69c211
refactor: remove unused isReady property from PopoverBond class
ryu-man Oct 31, 2025
4dcf513
bump version to 1.0.0-alpha.23
ryu-man Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@svelte-atoms/core",
"version": "1.0.0-alpha.22",
"version": "1.0.0-alpha.23",
"description": "A modular, accessible, and extensible Svelte UI component library.",
"repository": {
"type": "git",
Expand Down
6 changes: 0 additions & 6 deletions src/lib/components/popover/bond.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ export class PopoverBond<
static CONTEXT_KEY = '@atomic-sv/bonds/popover';

#position = $state<ComputePositionReturn>();
#isReady = Promise.withResolvers();

constructor(state: State) {
super(state);
Expand All @@ -69,10 +68,6 @@ export class PopoverBond<
return this.#position;
}

get isReady() {
return this.#isReady.promise;
}

trigger(props: Record<string, unknown> = {}) {
const isButtonElement = isBrowser()
? this.elements.trigger instanceof HTMLButtonElement
Expand Down Expand Up @@ -117,7 +112,6 @@ export class PopoverBond<
...props,
onchange: (node: HTMLElement, position: ComputePositionReturn) => {
this.#position = position;
this.#isReady.resolve(position);
}
});

Expand Down