Skip to content

fix: next steps prompt order#166

Merged
AdrianGonz97 merged 6 commits intomainfrom
chore/next-steps-cleanup
Oct 17, 2024
Merged

fix: next steps prompt order#166
AdrianGonz97 merged 6 commits intomainfrom
chore/next-steps-cleanup

Conversation

@AdrianGonz97
Copy link
Copy Markdown
Member

closes #165

this pr just puts them one after the other instead of combining them, but the ability to combine them should be easier now if we choose to do so in the future

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: 780f0fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Oct 17, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@166

commit: 780f0fd

@manuel3108
Copy link
Copy Markdown
Member

Can we easily invert the order? Logically i would expect the project next steps first, and then the integration next steps

@AdrianGonz97
Copy link
Copy Markdown
Member Author

interesting point! that makes sense given the order of the prompts. will update

@AdrianGonz97
Copy link
Copy Markdown
Member Author

AdrianGonz97 commented Oct 17, 2024

here's a quick comparison:

before:

◇  Which package manager do you want to install dependencies with?
│  None
│
◇  Integration next steps ─────────────────────────────────────────────╮
│                                                                      │
│  - You will need to set DATABASE_URL in your production environment  │
│  - Run npm run db:push to update your database schema                │
│                                                                      │
├──────────────────────────────────────────────────────────────────────╯
│
◇  Project next steps ─────────────────────────────────────────────────────╮
│                                                                          │
│  1: cd foobars                                                           │
│  2: npm install                                                          │
│  3: git init && git add -A && git commit -m "Initial commit" (optional)  │
│  4: npm run dev -- --open                                                │
│                                                                          │
│  To close the dev server, hit Ctrl-C                                     │
│                                                                          │
│  Stuck? Visit us at https://svelte.dev/chat                              │
│                                                                          │
├──────────────────────────────────────────────────────────────────────────╯
│
└  You're all set!

after:

◇  Successfully installed dependencies
│
◇  Project next steps ─────────────────────────────────────────────────────╮
│                                                                          │
│  1: cd foobarsa2                                                         │
│  2: git init && git add -A && git commit -m "Initial commit" (optional)  │
│  3: pnpm run dev -- --open                                               │
│                                                                          │
│  To close the dev server, hit Ctrl-C                                     │
│                                                                          │
│  Stuck? Visit us at https://svelte.dev/chat                              │
│                                                                          │
├──────────────────────────────────────────────────────────────────────────╯
│
◇  Integration next steps ─────────────────────────────────────────────╮
│                                                                      │
│  - You will need to set DATABASE_URL in your production environment  │
│  - Run npm run db:push to update your database schema                │
│                                                                      │
├──────────────────────────────────────────────────────────────────────╯
│
└  You're all set!

logically, the order makes sense. though i'm not exactly sure how i feel about it just yet. don't know if the feeling is because i'm used to the old order or not. i'll give it some time to get used to it though.

Copy link
Copy Markdown
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this feels way more natural now. Additionaly i'm going to read from top to bottom and need to apply those command from top to bottom as well.

Sure this feels different, but i think this is the only correct way.

@AdrianGonz97 AdrianGonz97 merged commit 579c5a8 into main Oct 17, 2024
@AdrianGonz97 AdrianGonz97 deleted the chore/next-steps-cleanup branch October 17, 2024 16:18
@github-actions github-actions Bot mentioned this pull request Oct 17, 2024
@benmccann
Copy link
Copy Markdown
Member

I think the one potential issue would be if one of the integration next steps includes something you need to do to get your project to run. Then having the project next steps first with pnpm run dev could give you a broken experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cleanup next steps and prompt order

3 participants