Skip to content

Conversation

jycouet
Copy link
Contributor

@jycouet jycouet commented Oct 16, 2025

Closes: #736

Copy link

changeset-bot bot commented Oct 16, 2025

🦋 Changeset detected

Latest commit: f1a7ea2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 16, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@737
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@737

commit: f1a7ea2

Copy link
Member

@Conduitry Conduitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be checking whether either file exists before going ahead and creating compose.yaml. We don't want to create compose.yaml if someone already has a docker-compose.yml. While we're at it, we should maybe also check for docker-compose.yaml.

@jycouet
Copy link
Contributor Author

jycouet commented Oct 17, 2025

We should be checking whether either file exists before going ahead and creating compose.yaml. We don't want to create compose.yaml if someone already has a docker-compose.yml. While we're at it, we should maybe also check for docker-compose.yaml.

Thank you for looking and the feedback.
I could probably do quick fixes taking this into account, but maybe we should do one step back and rethink a few things.

In random order:
F. Our tests should have failed with my small change.
E. When a docker-compose.yml existed, we don't modify it, and we don't tell anything to the user
Y. We now have a yaml parser, we could edit xxx.yaml config
A. Drizzle add should add a first db. But when you run it a second time should it add a second db, or cancel (and explain)? (we speak about it here: #704 (comment) would be great to have your view)

@jycouet jycouet mentioned this pull request Oct 17, 2025
2 tasks
@jycouet
Copy link
Contributor Author

jycouet commented Oct 17, 2025

I'll close here in favor of this one: #738
It's taking into account your requests @Conduitry 👍
Thx

@jycouet jycouet closed this Oct 17, 2025
@manuel3108 manuel3108 deleted the feat/docker branch October 18, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generated Docker Compose file should use compose.yaml instead of docker-compose.yml

2 participants