Skip to content

Conversation

jycouet
Copy link
Contributor

@jycouet jycouet commented Oct 17, 2025

Closes: #737
Closes: #701

  • Added more tests
  • Added a cancel option in run step. It's a bit different than unsupported in the setup step.
    A/ It allows the plugin to be visible
    B/ It reports the reason of the cancel
    C/ Will help for create & add in one go issue

Copy link

changeset-bot bot commented Oct 17, 2025

🦋 Changeset detected

Latest commit: ca5f23e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 17, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@738
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@738

commit: ca5f23e

Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is working as expected.

I create a clean project:

┌  Welcome to the Svelte CLI! (v0.9.8)
│
◇  Where would you like your project to be created?
│  ./
│
◇  Directory not empty. Continue?
│  Yes
│
◇  Which template would you like?
│  SvelteKit minimal
│
◇  Add type checking with TypeScript?
│  Yes, using TypeScript syntax
│
◆  Project created
│
◇  What would you like to add to your project? (use arrow keys / space bar)
│  none
│
◇  Which package manager do you want to install dependencies with?
│  pnpm
│
◆  Successfully installed dependencies
│
◇  What's next? ───────────────────────────────╮
│                                              │
│  📁 Project steps                            │
│                                              │
│    1: pnpm run dev --open                    │
│                                              │
│  To close the dev server, hit Ctrl-C         │
│                                              │
│  Stuck? Visit us at https://svelte.dev/chat  │
│                                              │
├──────────────────────────────────────────────╯
│
└  You're all set!

doing a sv add afterwards

┌  Welcome to the Svelte CLI! (v0.9.8)
│
◆  What would you like to add to your project? (use arrow keys / space bar)
│  ◻ prettier (formatter - https://prettier.io)
│  ◻ eslint
│  ◻ vitest
│  ◻ playwright
│  ◻ tailwindcss
│  ◻ devtools-json
│  ◻ mdsvex
│  ◻ storybook
└

The list above is missing at least drizzle, since i did not select any addon initially. Not sure if this is missing other addons as well.

Co-authored-by: Manuel <30698007+manuel3108@users.noreply.github.com>
@jycouet jycouet mentioned this pull request Oct 18, 2025
Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My last issues has been resolved by #740, everything works as expected now.

@manuel3108 manuel3108 merged commit 921d37a into main Oct 18, 2025
8 checks passed
@manuel3108 manuel3108 deleted the feat/docker-improvements branch October 18, 2025 14:32
@github-actions github-actions bot mentioned this pull request Oct 18, 2025
@jycouet
Copy link
Contributor Author

jycouet commented Oct 18, 2025

Closing #736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add drizzle (sometime visible, sometime not)

2 participants