-
-
Notifications
You must be signed in to change notification settings - Fork 69
add create-with-all-addons snapshot
#831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
commit: |
|
Right now it's without I tried it... And I'm sure we can tune a few defaults. Maybe later? |
manuel3108
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first file i touched to test if it works was package.json which of course is the only one that didn't had a new line at the end, which immediately make prettier angry. So i just added a commit to ensure we always add a new line at the end of the tested files.
We also do this for other tests as well:
cli/packages/core/tests/js/index.ts
Line 26 in d4f0169
| if (!output.endsWith('\n')) output += '\n'; |
Feel free to merge if you disagree with my other comment, no opinion on that one.
Closes #830
To regenerate the snapshot delete the folder
packages/cli/tests/create-with-all-addons