Skip to content

Conversation

@jycouet
Copy link
Contributor

@jycouet jycouet commented Nov 30, 2025

Closes #830

To regenerate the snapshot delete the folder packages/cli/tests/create-with-all-addons

@changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2025

⚠️ No Changeset found

Latest commit: 6514052

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 30, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@831
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@831

commit: 6514052

@jycouet
Copy link
Contributor Author

jycouet commented Nov 30, 2025

Right now it's without format (faster!).

I tried it... And I'm sure we can tune a few defaults. Maybe later?

Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first file i touched to test if it works was package.json which of course is the only one that didn't had a new line at the end, which immediately make prettier angry. So i just added a commit to ensure we always add a new line at the end of the tested files.

We also do this for other tests as well:

if (!output.endsWith('\n')) output += '\n';

Feel free to merge if you disagree with my other comment, no opinion on that one.

@jycouet jycouet merged commit 6004a22 into main Dec 2, 2025
8 checks passed
@jycouet jycouet deleted the fet/add-snapshot-test branch December 2, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

snapshot testing addons

3 participants